Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Suggestions and Explanations #31

Open
ethel-dev opened this issue Oct 13, 2014 · 5 comments
Open

More Suggestions and Explanations #31

ethel-dev opened this issue Oct 13, 2014 · 5 comments
Labels

Comments

@ethel-dev
Copy link

I think you should add more explanations as to what a Test Suite is?

@basicallydan
Copy link
Owner

I agree, I'll do that! The explanations are a bit sparse in general.

@ethel-dev
Copy link
Author

Great!

@basicallydan
Copy link
Owner

I'm gonna keep this open actually, just as a reminder! :)

@hpoom
Copy link

hpoom commented Dec 2, 2014

Can I work on the Suggestions section?

I think it should be changed from a popup to expanding out the ⚠️ icons when clicked/touched on. At the moment it appears explanation fires up a popup but that can probably be done better with inline suggestions.

Maybe I should make another issue for the display of the suggestions as it detracts from this issue. Also another for expanding out Licence document which I am more than happy to write and do a PR for.

@basicallydan
Copy link
Owner

Can I work on the Suggestions section?

Please do and thank you for offering! I'm glad to see you found some time @hpoom! I still haven't since I made this repo sadly :(

I agree that the popup isn't sustainable. It will quickly get massive and annoying. I'll talk more about that in #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants