Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ci pre commit and linter #910

Open
lowtorola opened this issue Jan 14, 2025 · 0 comments
Open

update ci pre commit and linter #910

lowtorola opened this issue Jan 14, 2025 · 0 comments
Assignees
@nour-massri
Labels
module: devops Related to deployments and other operations priority: p3 low type: refactor Codebase refactors or structure changes

Comments

@lowtorola
Copy link
Contributor

  • add tsc and a non-diff generate types check to ci (i.e. running generate_types.sh shouldn't result in a diff)
  • the eslint linter shouldn't block you from developing when you have errors
  • pre commit should block commit on eslint fail (and try to fix) just like we have for python
@lowtorola lowtorola added priority: p3 low module: devops Related to deployments and other operations type: refactor Codebase refactors or structure changes labels Jan 14, 2025
@nour-massri nour-massri self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nour-massri nour-massri

Labels
module: devops Related to deployments and other operations priority: p3 low type: refactor Codebase refactors or structure changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lowtorola @nour-massri