Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify global exclusions with bzlmod #1316

Open
joca-bt opened this issue Jan 27, 2025 · 0 comments
Open

Clarify global exclusions with bzlmod #1316

joca-bt opened this issue Jan 27, 2025 · 0 comments

Comments

@joca-bt
Copy link
Contributor

joca-bt commented Jan 27, 2025

There are two fields related to global exclusions in the bzlmod version, viz. exclusions and excluded_artifacts, and it is not clear what is the difference between them. In the non-bzlmod version there's only excluded_artifacts.

When I try to exclude artifacts through the exclusions field nothing seems to be excluded: the artifacts are still present in the json and listed as dependencies (I'm using a lock file - pinning). When using excluded_artifacts it works as expected.

It seems that the implementation function (maven_impl) doesn't refer to the exclusions field at all. Could this be a leftover that needs to be cleaned?

On Bazel 7.4.1 and rules_jvm_external 6.6.

@joca-bt joca-bt changed the title Global exclusions doesn't seem to work with bzlmod Clarify global exclusions with bzlmod Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant