Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starlark debugger is broken in 0.11.0 #432

Open
dpar39 opened this issue Jan 28, 2025 · 0 comments
Open

Starlark debugger is broken in 0.11.0 #432

dpar39 opened this issue Jan 28, 2025 · 0 comments

Comments

@dpar39
Copy link

dpar39 commented Jan 28, 2025

This change broke the starlark debugger:

https://github.com/bazel-contrib/vscode-bazel/pull/384/files#diff-f3f20d3eedcd2c0127856ac96df3014f449e9e6324f5dcd3b9ae526693f44222R170

How? Firstly this.bazelInfo is meant to be a Map<string, string>>, not an instance of BazelInfo. But the root cause is that the debugger program can't resolve the vscode import which got inserted as a dependency from BazelComand.

node ./out/src/debug-adapter/client.js
node:internal/modules/cjs/loader:1247
  throw err;
  ^

Error: Cannot find module 'vscode'
Require stack:
- /home/dpar39/code/vscode-bazel/out/src/bazel/bazel_command.js
- /home/dpar39/code/vscode-bazel/out/src/bazel/bazel_info.js
- /home/dpar39/code/vscode-bazel/out/src/debug-adapter/client.js
    at Function._resolveFilename (node:internal/modules/cjs/loader:1244:15)
    at Function._load (node:internal/modules/cjs/loader:1070:27)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
    at Module.require (node:internal/modules/cjs/loader:1335:12)
    at require (node:internal/modules/helpers:136:16)
    at Object.<anonymous> (/home/dpar39/code/vscode-bazel/out/src/bazel/bazel_command.js:17:16)
    at Module._compile (node:internal/modules/cjs/loader:1562:14)
    at Object..js (node:internal/modules/cjs/loader:1699:10)
    at Module.load (node:internal/modules/cjs/loader:1313:32) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/dpar39/code/vscode-bazel/out/src/bazel/bazel_command.js',
    '/home/dpar39/code/vscode-bazel/out/src/bazel/bazel_info.js',
    '/home/dpar39/code/vscode-bazel/out/src/debug-adapter/client.js'
  ]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant