We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppose the following (loosely ripped from tests/zip/BUILD):
tests/zip/BUILD
load("@rules_pkg//pkg:mappings.bzl", "pkg_files", "REMOVE_BASE_DIRECTORY") load("@rules_pkg//pkg:zip.bzl", "pkg_zip") # load("...:directory.bzl", "directory") # something that creates a directory/treeartifact pkg_zip( name = "test_zip_tree_remove_base_directory", srcs = [":generate_tree_remove_base_directory"], ) pkg_files( name = "generate_tree_remove_base_directory", srcs = [":generate_tree"], renames = {":generate_tree": REMOVE_BASE_DIRECTORY}, ) directory( name = "generate_tree", ... )
When built, the resulting archive contains a "/" entry:
$ zipinfo -1 bazel-bin/tests/zip/test_zip_tree_remove_base_directory.zip / a/ a/a a/b/ a/b/c b/ b/c/ b/c/d b/d b/e
I believe this is a minor regression from #640 .
The text was updated successfully, but these errors were encountered:
fix: avoid creating "/" zip entry when using REMOVE_BASE_DIRECTORY
5472f7b
This is just a quick fix to handle the special case of mapping a tree artifact to the root of a zip archive. Resolves bazelbuild#927.
rbeasley-avgo
Successfully merging a pull request may close this issue.
Suppose the following (loosely ripped from
tests/zip/BUILD
):When built, the resulting archive contains a "/" entry:
I believe this is a minor regression from #640 .
The text was updated successfully, but these errors were encountered: