Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix #1248] [installer] provide switch to leave .emacs untouched #1297

Closed
wants to merge 1 commit into from

Conversation

sankalp-khare
Copy link

Provide an option in the installer to not perform the backup/move action on the user's .emacs

  • Add a command-line switch -m/--no-move-dotemacs in the utils/installer.sh shell script, in the same style as existing switches.
  • Add a condition to the if block that performs the .emacs move-to-backup-location action.
  • Update changelog.

note: none of the existing installer options are documented in the doc/installation.md so I didn't change anything there.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality like modules, commands, configuration options, etc)

Thanks!

 - if the user specifies the `-m/--no-move-dotemacs` option the installer will
   not invoke the backup `$HOME/.emacs` code block
# -n/--no-bytecompile
# Skip the compilation of the prelude files.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just done for consistency with the rest of the one-line-description args documented in the comment block.

@bbatsov
Copy link
Owner

bbatsov commented Nov 25, 2020

note: none of the existing installer options are documented in the doc/installation.md so I didn't change anything there.

Great point. Probably we should do this at some point. :-)

What's the problem you're trying to solve with this change? Seems a bit weird not to move .emacs as it will take precedence over whatever is in .emacs.d.

@sankalp-khare
Copy link
Author

@bbatsov I filed this due to #1248

@stale
Copy link

stale bot commented Jun 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

@stale stale bot added the stale label Jun 3, 2021
@stale
Copy link

stale bot commented Jul 8, 2021

This issues been automatically closed due to lack of activity. Feel free to re-open it if you ever come back to it.

@stale stale bot closed this Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants