-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
year of census data #106
Comments
@boshek does {bcmaps} get the Census data from the BC Data Catalogue via {bcdata}? |
It does. It doesn't have to be that way but that is the current workflow. |
So maybe the {bcmaps} package should follow the API in the B.C. Data Catalogue, which appears to be a record for each census year? Which I guess is a +1 for this option from your list:
|
Forgot a word in there:
But yeah that logic makes tons on sense. Adding an argument means only minimal breaking changes. |
I would lean to this option:
This design aligns better with the the other functions/the overall package imo -- one function per record. Re: breaking changes, we could leave the current set of And now that I have said all that, I have to say that I think option 1 is good too. If {bcmaps} is a package of convenience functions, then perhaps just the most recent year census boundaries would suffice? We could add some documentation re: using {bcdata} to get the older versions. |
Now that census geographies are being updated in the catalogue to 2021 we will need to think about how to manage this. I see three options:
census_*
that specifies the year of the census with the current boundary at the default (create new functionscensus_2016_*
andcensus_2021_*
)The text was updated successfully, but these errors were encountered: