Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Bool? #128

Open
ericphanson opened this issue Aug 12, 2022 · 0 comments
Open

Support Bool? #128

ericphanson opened this issue Aug 12, 2022 · 0 comments

Comments

@ericphanson
Copy link
Member

Can be useful for dense multichannel true/false labels. One can just use UInt8's, but if only true/false is allowed then Bool is a natural representation for it, and moreover if whatever process is generating these labels outputs Matrix{Bool}, then if Onda supported Bool, it could be wrapped in Samples and encoded/decoded without copying.

Onda allows us to skip the copy if sample_type === eltype(sample_data) && sample_resolution_in_unit == 1 && sample_offset_in_unit == 0 but that means the label generating process would need to output UInt8's instead of Bools which can be less natural.

Additionally, maybe Onda could bitpack the Bools i.e. support a storage format like BitMatrix for 8x storage savings, although that sounds like a bigger lift to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant