Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename noContent to isEmpty? Or at least alias it? #249

Open
fracz opened this issue Mar 21, 2018 · 1 comment · May be fixed by #272
Open

Rename noContent to isEmpty? Or at least alias it? #249

fracz opened this issue Mar 21, 2018 · 1 comment · May be fixed by #272

Comments

@fracz
Copy link

fracz commented Mar 21, 2018

I have noticed the noContent assertion when I was about to submit a PR with an isEmpty implementation.

Why the asserion is called noContent? It does the opposite from notEmpty and IMO the clearest name for this check is isEmpty.
@rquadling
Copy link
Contributor

To preserve backward compatibility, an alias would be needed.

Happy to look at a PR for this.

@Taluu Taluu linked a pull request Dec 27, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a empty alias for noContent Taluu/beberlei-assert
2 participants
@rquadling @fracz