Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are MusicBrainz Track (Recording) IDs saved as UFID in MP3s while all other MusicBrainz IDs are saved as TXXX? #79

Open
quantenzitrone opened this issue Sep 1, 2024 · 5 comments
Assignees

Comments

@quantenzitrone
Copy link

It has been like that since the beginning of MusicBrainz ID support
beetbox/beets@ac98777

ping @sampsyo as the original commit author on that

I stumbled over this while trying another musicbrainz/beets related tool Serene-Arc/listenbrainz-playlist-uploader#5

@quantenzitrone
Copy link
Author

Furthermore, I think it shouldn't be named mb_trackid, as this is very confusing since the field saves the Recording ID.
MusicBrainz docs call the mb_releasetrackids just tracks: https://musicbrainz.org/doc/MusicBrainz_Identifier

@jackwilsdon
Copy link
Member

jackwilsdon commented Sep 1, 2024

If I had to take a guess, it's UFID as that's what Picard uses:

https://github.com/metabrainz/picard/blob/e17ecfbad066a7019a675a8b201467ed8bbbbe6a/picard/formats/id3.py#L505-L506

https://github.com/metabrainz/picard/blob/e17ecfbad066a7019a675a8b201467ed8bbbbe6a/picard/formats/id3.py#L366-L367

And this reply seems to explain why it's named mb_trackid: beetbox/beets#2690 (comment) (it sounds like MB used to call it "track id")

@quantenzitrone
Copy link
Author

ok that makes a lot of sense

@Serene-Arc
Copy link

Seems strange that the URL it produces is malformed though, I'll need to take a look.

@Serene-Arc Serene-Arc self-assigned this Sep 2, 2024
@quantenzitrone
Copy link
Author

its not meant to be an url i think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants