From 898719a91c314dbff926cb9a6383d4a9082b265d Mon Sep 17 00:00:00 2001 From: Ben Pollard <129943363+benpollarduk@users.noreply.github.com> Date: Wed, 4 Dec 2024 22:42:35 +0000 Subject: [PATCH 1/2] Update Ansi.cs --- NetAF/Rendering/Console/Ansi.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NetAF/Rendering/Console/Ansi.cs b/NetAF/Rendering/Console/Ansi.cs index db743154..1b3d1a77 100644 --- a/NetAF/Rendering/Console/Ansi.cs +++ b/NetAF/Rendering/Console/Ansi.cs @@ -31,14 +31,14 @@ public static class Ansi /// /// Determine if color is suppressed. If the NO_COLOR environment variable is present and set to anything other than '0' or 'false' this will return true. /// - /// True if the NO_COLOR environment variable is present and set to anything other than '0' or 'false', else false. + /// True if the NO_COLOR environment variable is present and set to anything other than an empty string, else false. public static bool IsColorSuppressed() { var value = Environment.GetEnvironmentVariable(NO_COLOR)?.ToLower() ?? string.Empty; return value switch { - "" or "0" or "false" => false, + "" => false, _ => true, }; } From cfb49345937681250f5fc71f47bf9e2c59bfe226 Mon Sep 17 00:00:00 2001 From: Ben Pollard <129943363+benpollarduk@users.noreply.github.com> Date: Wed, 4 Dec 2024 22:43:59 +0000 Subject: [PATCH 2/2] Update Ansi_Tests.cs --- NetAF.Tests/Rendering/Console/Ansi_Tests.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/NetAF.Tests/Rendering/Console/Ansi_Tests.cs b/NetAF.Tests/Rendering/Console/Ansi_Tests.cs index 90f5684b..deb9692d 100644 --- a/NetAF.Tests/Rendering/Console/Ansi_Tests.cs +++ b/NetAF.Tests/Rendering/Console/Ansi_Tests.cs @@ -18,23 +18,23 @@ public void GivenNoColorEnvironmentVariableSetToEmptyString_WhenIsColorSuppresse } [TestMethod] - public void GivenNoColorEnvironmentVariableSetTo0_WhenIsColorSuppressed_ThenReturnFalse() + public void GivenNoColorEnvironmentVariableSetTo0_WhenIsColorSuppressed_ThenReturnTrue() { Environment.SetEnvironmentVariable(Ansi.NO_COLOR, "0"); var result = Ansi.IsColorSuppressed(); - Assert.IsFalse(result); + Assert.IsTrue(result); } [TestMethod] - public void GivenNoColorEnvironmentVariableSetToFalse_WhenIsColorSuppressed_ThenReturnFalse() + public void GivenNoColorEnvironmentVariableSetToFalse_WhenIsColorSuppressed_ThenReturnTrue() { Environment.SetEnvironmentVariable(Ansi.NO_COLOR, "False"); var result = Ansi.IsColorSuppressed(); - Assert.IsFalse(result); + Assert.IsTrue(result); } [TestMethod]