Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Builder should cancel workflow after sigterm received and not wait until the whole workflow finishes #1329

Closed
2 tasks
Despire opened this issue Apr 8, 2024 · 1 comment
Labels
feature New feature

Comments

@Despire
Copy link
Contributor

Despire commented Apr 8, 2024

Description

Currently when Builder receives the sigterm signal it will finish whatever workflow is being executed (which can range from dozens of minutes up to hours depending on the size of the cluster being build), when a sigterm is recieved builder should only wait for the current step being executed (terraformer, ansibler etc..) and cancel any further steps. The current state should be written to the DB and picked up by the next pod.

The cancelation can be simply achieved by the correct use of context package

Exit criteria

  • Make builder exit on sigterm after finishing the current step instead of waiting for the whole workflow
  • Save the current state to DB so the next pod can pick it up where the old replica left off.
@Despire Despire added the feature New feature label Apr 8, 2024
@Despire Despire changed the title Feature: Builder cancels workflow after sigterm received Feature: Builder should cancel workflow after sigterm received Apr 8, 2024
@Despire Despire changed the title Feature: Builder should cancel workflow after sigterm received Feature: Builder should cancel workflow after sigterm received and not wait until the whole workflow finishes Apr 8, 2024
@Despire
Copy link
Contributor Author

Despire commented Apr 19, 2024

Duplicate of #1298

@Despire Despire marked this as a duplicate of #1298 Apr 19, 2024
@Despire Despire closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

1 participant