Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ui v1 #1

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Feature/ui v1 #1

wants to merge 15 commits into from

Conversation

mitchbregs
Copy link
Member

No description provided.

@@ -8,26 +8,26 @@ class SignUpForm(FlaskForm):
Class to encapsulate sign up form
"""
first_name = StringField(
'First Name:',
'First name',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the form created by wtf-forms do we ant space separated keys?

Copy link
Member Author

@mitchbregs mitchbregs Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might, but with the current UI there is no need since it looks like:

First name
---------------------------------
|                               |
---------------------------------

Have you launched this branch? Check it out and let me know. This is largely still a WIP PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't gotten to system test yet - will get to that later though

<section class="jumbotron text-center">
<div class="container">
<h1 class="jumbotron-heading">Bet smarter with groups.</h1>
<p class="lead text-muted">Something short and leading about the collection below—its contents, the creator, etc. Make it short and sweet, but not too short so folks don't simply skip over it entirely.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

Copy link
Collaborator

@leonkozlowski leonkozlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At glance - LGTM, - you can merge if you'd like, but i will do system test later

@mitchbregs
Copy link
Member Author

At glance - LGTM, - you can merge if you'd like, but i will do system test later

I'm still going to push along to this PR.. definitely check it out and let me know.

@mitchbregs mitchbregs force-pushed the feature/ui-v1 branch 2 times, most recently from 38f6d66 to a2b3646 Compare April 1, 2020 06:14
@@ -20,9 +20,9 @@
var myChart = new Chart(ctx, {
type: 'line',
data: {
labels: ["Sunday", "Monday", "Tuesday", "Wednesday", "Thursday", "Friday", "Saturday"],
labels: ["01/01/2020", "01/02/2020", "01/03/2020", "01/04/2020", "01/05/2020", "01/06/2020", "01/07/2020", "01/08/2020", "01/09/2020", "01/10/2020", "01/11/2020", "01/12/2020", "01/13/2020", "01/14/2020"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dummy values?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just a placeholder for now.

@mitchbregs mitchbregs linked an issue Apr 10, 2020 that may be closed by this pull request
@mitchbregs mitchbregs force-pushed the feature/ui-v1 branch 2 times, most recently from b32b575 to 5d892c3 Compare April 14, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maximum is 10000, validation is set at 1000
2 participants