Use eslint

.eslintrc.json

@@ -0,0 +1,13 @@
+{
+    "env": {
+        "browser": true,
+        "node": true,
+        "es6": true,
+        "commonjs": true
+    },
+    "extends": ["eslint:recommended", "prettier"],
+    "rules": {
+      "eqeqeq": ["error", "always"],
+      "no-alert": "error"
+    }
+}

package.json

@@ -19,8 +19,9 @@
   },
   "devDependencies": {
     "chai": "^4.1.2",
-    "jshint": "^2.9.5",
-    "jshint-loader": "^0.8.4",
+    "eslint": "^4.19.1",
+    "eslint-config-prettier": "^2.9.0",
+    "eslint-loader": "^2.0.0",
     "mocha": "^5.0.0",
     "prettier": "^1.12.1",
     "prettier-check": "^2.0.0",

src/mappers.js

@@ -498,6 +498,7 @@ Mappers[0].prototype = {
     // Does nothing. This is used by the MMC3 mapper.
   },
 
+  // eslint-disable-next-line no-unused-vars
   latchAccess: function(address) {
     // Does nothing. This is used by MMC2.
   },
@@ -741,6 +742,7 @@ Mappers[1].prototype.loadROM = function() {
   this.nes.cpu.requestIrq(this.nes.cpu.IRQ_RESET);
 };
 
+// eslint-disable-next-line no-unused-vars
 Mappers[1].prototype.switchLowHighPrgRom = function(oldSetting) {
   // not yet.
 };
@@ -1362,7 +1364,6 @@ Mappers[34].prototype.write = function(address, value) {
  */
 Mappers[66] = function(nes) {
   this.nes = nes;
-  console.log("Mapper 66");
 };
 
 Mappers[66].prototype = new Mappers[0]();

src/papu.js

@@ -150,6 +150,7 @@ PAPU.prototype = {
     this.minSample = 500000;
   },
 
+  // eslint-disable-next-line no-unused-vars
   readReg: function(address) {
     // Read 0x4015:
     var tmp = 0;
@@ -1300,6 +1301,7 @@ ChannelTriangle.prototype = {
     return this.lengthCounter === 0 || !this.isEnabled ? 0 : 1;
   },
 
+  // eslint-disable-next-line no-unused-vars
   readReg: function(address) {
     return 0;
   },

src/ppu.js

@@ -1150,8 +1150,6 @@ PPU.prototype = {
     var tIndexAdd = this.f_spPatternTable === 0 ? 0 : 256;
     var x, y, t, i;
     var bufferIndex;
-    var col;
-    var bgPri;
 
     x = this.sprX[0];
     y = this.sprY[0] + 1;
@@ -1164,8 +1162,6 @@ PPU.prototype = {
         // Sprite is in range.
         // Draw scanline:
         t = this.ptTile[this.sprTile[0] + tIndexAdd];
-        col = this.sprCol[0];
-        bgPri = this.bgPriority[0];
 
         if (this.vertFlip[0]) {
           toffset = 7 - (scan - y);
@@ -1248,8 +1244,6 @@ PPU.prototype = {
           }
         }
         toffset *= 8;
-        col = this.sprCol[0];
-        bgPri = this.bgPriority[0];
 
         bufferIndex = scan * 256 + x;
         if (this.horiFlip[0]) {
@@ -1575,7 +1569,7 @@ NameTable.prototype = {
             tx = basex + sqx * 2 + x;
             ty = basey + sqy * 2 + y;
             attindex = ty * this.width + tx;
-            this.attrib[ty * this.width + tx] = (add << 2) & 12;
+            this.attrib[attindex] = (add << 2) & 12;
           }
         }
       }

webpack.config.js

@@ -22,7 +22,7 @@ module.exports = {
         exclude: /node_modules/,
         use: [
           {
-            loader: "jshint-loader"
+            loader: "eslint-loader"
           }
         ]
       }