Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.0: --runonce doesn't work. #24

Open
HASJ opened this issue Oct 21, 2015 · 9 comments
Open

0.9.0: --runonce doesn't work. #24

HASJ opened this issue Oct 21, 2015 · 9 comments
Assignees

Comments

@HASJ
Copy link

HASJ commented Oct 21, 2015

Script just keeps running. Windows version.

@DanielOaks
Copy link
Contributor

Looks like f385ae7 may have something to do with it. Thanks for the report, will look into this and release a new version if need be!

@HASJ
Copy link
Author

HASJ commented Oct 21, 2015

No problem and thank YOU.

@HASJ HASJ closed this as completed Oct 31, 2015
@DanielOaks
Copy link
Contributor

Just wondering, was this closed because it's been fixed? If not, feel free to reopen it or I can create a new issue. Can take me a while to get around to things, but having an issue keeps it on my radar for when I have time to look!

@DanielOaks DanielOaks self-assigned this Oct 31, 2015
@DanielOaks DanielOaks added the bug label Oct 31, 2015
@HASJ HASJ reopened this Oct 31, 2015
@HASJ
Copy link
Author

HASJ commented Jan 8, 2016

--run_once doesn't work either. I should've reported this sooner but I forgot.

@DanielOaks
Copy link
Contributor

Alright, I do see where this issue is. I've got an initial fix over here, but I will need to modify the code with RLocks and such to make sure we don't cancel in-progress downloads (which right now, with that code, WILL HAPPEN A WHOLE LOT).

I'll keep you posted and post in here once I've fixed it properly and merged that into master.

@jcook12
Copy link

jcook12 commented Jan 23, 2016

Update on this fix?

@DanielOaks
Copy link
Contributor

Just been sidetracked for a while with other stuff. I should be able to
write up the last bit of this in the next day or two and push it to the
branch.

On 23 January 2016 at 11:00, jcook14 [email protected] wrote:

Update on this fix?


Reply to this email directly or view it on GitHub
#24 (comment)
.

@0XE4
Copy link

0XE4 commented Jan 24, 2016

Thanks @DanielOaks for your time, it will fix a really annoying bug!

@DanielOaks
Copy link
Contributor

No problem @0XE4, thanks for your comment!

The recently released v0.9.2 should fix this issue properly. Though it may take a while after finishing the last download to actually close the program, that's something I'll be looking at very soon. (fixed by 945af23 and in v0.9.3)

In other words: pip install --upgrade basc-archiver

Windows .exe releases are not yet updated, need to setup a new Windows environment since the laptop I could run VMs on died a while ago. Hopefully should be updated in the next day or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants