Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BSA file in quantms-utils is really bad #492

Closed
ypriverol opened this issue Mar 9, 2025 · 2 comments
Closed

BSA file in quantms-utils is really bad #492

ypriverol opened this issue Mar 9, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@ypriverol
Copy link
Member

Description of the bug

The test file in BSA https://github.com/bigbio/quantms-utils/blob/main/tests/test_data/BSA1_F1.mzML has too many errors, all of the has been seen in this PR, bigbio/quantms-utils#47 we should look for a better example file.

Command used and terminal output



Relevant files


No response


System information


No response

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @ypriverol
ypriverol




          added
  the 

  bug

  Something isn't working
 label


      Mar 9, 2025

    

  








      

  
      



  

  @ypriverol





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  Author


  


  

    

      

      
            ypriverol
  

      

      

      commented


        Mar 10, 2025


      
  •

  

    
      

        
          edited
          
        
        
      

    
    
      
        
      Loading

      
    
  



    


  





      


        


  
    

      
          
In this PR bigbio/quantms-utils#47 in favor of TMT_Erwinia_1uLSike_Top10HCD_isol2_45stepped_60min_01.mzML

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @ypriverol





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  Author


  


  

    

  





      


        


  
    

      
          
Already remove from the examples and tests in quantms-utils.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    











  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    bug

  Something isn't working








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
    

    Development
  




            
    
No branches or pull requests







      
    

  




      

    

  
      

  

    

      1 participant
    

    

        
          @ypriverol