Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipe character failing W3C validation #172

Open
flair-chris opened this issue Jul 24, 2019 · 2 comments
Open

pipe character failing W3C validation #172

flair-chris opened this issue Jul 24, 2019 · 2 comments

Comments

@flair-chris
Copy link

return `<link href="https://fonts.googleapis.com/css?family=${fonts.join('|')}&display=${fontDisplay}" rel="stylesheet">`;

Is it possible to use something like %7C instead of the pipe line?
We have a customer who has had their site inspected by an SEO expert and apparently these kind of "HTML errors" don't help. They just put the site through the w3c html validator and this comes up as an error.

@bookernath
Copy link
Contributor

Thanks @flair-chris, we'll take a look at this.

I found this which seems to agree with your suggestion: https://stackoverflow.com/questions/22466913/google-fonts-url-break-html5-validation-on-w3-org

@flair-chris
Copy link
Author

@bookernath Thanks for considering it.
Yeah that was the post i saw, i should have referenced that sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants