Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and cleanup iRODS data request view tests #2062

Open
mikkonie opened this issue Jan 24, 2025 · 0 comments
Open

Refactor and cleanup iRODS data request view tests #2062

mikkonie opened this issue Jan 24, 2025 · 0 comments
Labels
app: samplesheets Issue in the samplesheets app internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Milestone
v1.1.0

Comments

@mikkonie
Copy link
Contributor

These seem to contain a lot of problems:

  • Non-standard variable names
  • Seemingly unnecessary calls to POST requests to set things up instead of using model helpers, as is the standard
  • Helper methods defined as protected in base test class
  • Etc etc.

Not urgent, can be done in v1.1 together with #1865.
@mikkonie mikkonie added internal Changes invisible to the user or APIs (e.g. refactoring and optimization) app: samplesheets Issue in the samplesheets app labels Jan 24, 2025
@mikkonie mikkonie added this to the v1.1.0 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app: samplesheets Issue in the samplesheets app internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
1 participant
@mikkonie