Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize "default lengths" between feature metadata / sample metadata / length-scaling feature metadata barplots #358

Open
fedarko opened this issue Aug 28, 2020 · 0 comments

Comments

@fedarko
Copy link
Collaborator

fedarko commented Aug 28, 2020

Desired changes

  • On changing between sample and feature metadata barplots, the "Default length" / "Length" values should be updated to what they were in the previous tab.
  • On enabling / disabling length scaling for feature metadata barplots, the "Maximum length" and "Default length" values should be updated to match each other.

These changes might be frustrating if a user purposefully wants a sample metadata barplot with a different length than a feature metadata barplot or whatever, but for most users this should smooth out the UI.

Discussion

From @ElDeveloper, in #357:


I just noticed something a bit off with the bar scaling, maybe worth fixing here? When you click on the scale checkbox and you have a length different to 100 (the default), the maximum length is set by default to 100. I think this should by default be the maximum length so that bars don't shrink out of the blue. See this animated gif:

default-length

Thoughts?


Another reply in #357:


That's a really good point, and I agree that the UI for this is a bit confusing. Part of the challenge here is that, if the user has already done some length-scaling stuff for a layer, I'm not sure we want to mess with that when the user switches back to non-length-scaling -- do you think an acceptable compromise would be setting the "max length" for scaling to the default length the first time the "length scaling" checkbox is checked? Or maybe we should just update it every time.

I guess in the same vein we should definitely synchronize the default lengths between feature and sample metadata barplots --

asdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant