Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SEED Subsystem #1339

Closed
samseaver opened this issue Jan 6, 2025 · 1 comment · Fixed by #1365
Closed

Update SEED Subsystem #1339

samseaver opened this issue Jan 6, 2025 · 1 comment · Fixed by #1365
Labels
Update Used in combination with prefix, metaprefix, or collection for updates to entries

Comments

@samseaver
Copy link
Contributor

Prefix

seed

Explanation

The seed.subsystem synonym should be removed and used to create it's own entry as a prefix. This follows the convention of having sub-prefixes that are indicative of the data type. For example there are a seed.compound and seed.reaction entries, and I will be shortly proposing a new seed.role entry.

Contributor ORCID

0000-0002-7674-5194
@samseaver samseaver added the Update Used in combination with prefix, metaprefix, or collection for updates to entries label Jan 6, 2025
@cthoyt
Copy link
Member

cthoyt commented Jan 6, 2025

That's a good point, we could swap seed.subsystem to be the primary prefix for consistency. It's not clear how this relates to other potential SEED prefixes, so lets wait for discussion on #1340 and others before making the swap

This was referenced Jan 17, 2025
Closed
Merged
bgyori added a commit that referenced this issue Jan 18, 2025
@nalikapalayoor @bgyori
Update prefix: seed --> seed.subsystem (#1365)
32b809f 
After reviewing the current prefixes associated with The Seed, we
decided to update the name of the 'seed' prefix to be 'seed.subsystems',
and have 'seed' be a synonym for it instead. This PR makes this update,
and also updates the 'uri_format' for 'seed.subsystems' to be a working
url, as the old one seems to be outdated.

Fixes #1339

---------

Co-authored-by: Benjamin M. Gyori <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Update Used in combination with prefix, metaprefix, or collection for updates to entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update prefix: seed --> seed.subsystem nalikapalayoor/bioregistry
2 participants
@samseaver @cthoyt