Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit Smoldyn 2.73 #665

Closed
16 tasks done
AlexPatrie opened this issue Feb 15, 2024 · 3 comments
Closed
16 tasks done

Submit Smoldyn 2.73 #665

AlexPatrie opened this issue Feb 15, 2024 · 3 comments
Labels
Invalid This doesn't seem right Validate/submit simulator Validate a simulation tool or request its submission to the BioSimulators registry

Comments

@AlexPatrie
Copy link

AlexPatrie commented Feb 15, 2024

Simulation tool


id: smoldyn
version: "2.73"
specificationsUrl: https://github.com/ssandrews/Smoldyn/blob/master/biosimulators.json
specificationsPatch:
version: "2.73"
validateImage: true
commitSimulator: true

Support for BioSimulators' conventions

@AlexPatrie AlexPatrie added the Validate/submit simulator Validate a simulation tool or request its submission to the BioSimulators registry label Feb 15, 2024
@biosimulators-daemon biosimulators-daemon added the Invalid This doesn't seem right label Feb 15, 2024
@biosimulators-daemon
Copy link

The validation/submission of your simulator failed.

- Simulator submissions should only use the keys "id", "version", "specificationsUrl", "specificationsPatch", validateImage", and "commitSimulator". The following keys are invalid:
-   - digest
-   - image
-   - url

The complete log of your validation/submission job, including further information about the failure, is available for 90 days here.

If you chose to validate your Docker image, the results of the validation of your image will be available shortly as a JSON file. A link to this file will be available for 90 days from the "Artifacts" section at the bottom of this page.

Once you have fixed the problem, edit the first block of this issue to re-initiate this validation.

The BioSimulators Team is happy to help. Questions and feedback can be directed to the BioSimulators Team by posting comments to this issues that reference the GitHub team @biosimulators/biosimulators (without the backticks).

@biosimulators-daemon
Copy link

Thank you @AlexPatrie for your submission to the BioSimulators simulator validation/submission system!

The BioSimulators validator bot is validating the specifications of your simulator, validating your Docker image, and committing your simulator to the BioSimulators registry.

We will discuss any concerns with your submission in this issue.

A complete log of your simulator submission job will be available for 90 days here. The results of the validation of your tool will also be saved as a JSON file. A link to this file will be available for 90 days from the "Artifacts" section at the bottom of this page.

@biosimulators-daemon biosimulators-daemon added Invalid This doesn't seem right and removed Invalid This doesn't seem right labels Feb 15, 2024
@biosimulators-daemon
Copy link

The validation/submission of your simulator failed.

- The simulator specifications from `https://github.com/ssandrews/Smoldyn/blob/master/biosimulators.json` are invalid. The specifications of simulation tools must adhere to BioSimulators' schema. BioSimulators' schema is available in both JSON Schema and Open API Specifications formats. Documentation is available at https://api.biosimulators.org/.
- 
-   - Bad Request (400):
-     
-       Object is invalid: Property or parameter 'payload' is invalid.
-       
-         Value:
-           {
-             allShortcutsEnabled: false,
-             fileTree: { '': { items: [Array], totalCount: 22 } },
-             fileTreeProcessingTime: 3.785273,
-             foldersToFetch: [],
-             repo: {
-               id: 172146454,
-               defaultBranch: 'master',
-               name: 'Smoldyn',
-               ownerLogin: 'ssandrews',
-               currentUserCanPush: false,
-               isFork: false,
-               isEmpty: false,
-               createdAt: '2019-02-22T23:06:41.000Z',
-               ownerAvatar: 'https://avatars.githubusercontent.com/u/33039297?v=4',
-               public: true,
-               private: false,
-               isOrgOwned: false
-             },
-             symbolsExpanded: false,
-             treeExpanded: true,
-             refInfo: {
-               name: 'master',
-               listCacheKey: 'v0:1707141404.0',
-               canEdit: false,
-               refType: 'branch',
-               currentOid: 'ca9d2c92e1f59b795c560ed65a6b5b84e943899f'
-             },
-             path: 'biosimulators.json',
-             currentUser: null,
-             blob: {
-               rawLines: [
-                 '{',
-                 '  "id": "smoldyn",',
-                 '  "name": "Smoldyn",',
-                 '  "version": "2.72",',
-                 '  "description": "Computer program for cell-scale biochemical simulations.",',
-                 '  "urls": [{',
-                 '      "title": null,',
-                 '      "type": "Home page",',
-                 '      "url": "http://www.smoldyn.org/"',
-                 '    },',
-                 '    {',
-                 '      "title": null,',
-                 '      "type": "Examples",',
-                 '      "url": "http://www.smoldyn.org/archive.html"',
-                 '    },',
-                 '    {',
-                 '      "title": null,',
-                 '      "type": "Installation instructions",',
-                 '      "url": "https://smoldyn.readthedocs.io/en/latest/user/install.html"',
-                 '    },',
-                 '    {',
-                 '      "title": null,',
-                 '      "type": "Documentation",',
-                 '      "url": "https://smoldyn.readthedocs.io/"',
-                 '    },',
-                 '    {',
-                 '      "title": null,',
-                 '      "type": "Source repository",',
-                 '      "url": "https://github.com/ssandrews/Smoldyn"',
-                 '    },',
-                 '    {',
-                 '      "title": null,',
-                 '      "type": "License",',
-                 '      "url": "https://github.com/ssandrews/Smoldyn/blob/master/LICENSE"',
-                 '    },',
-                 '    {',
-                 '      "title": null,',
-                 '      "type": "Issue tracker",',
-                 '      "url": "https://github.com/ssandrews/Smoldyn/issues"',
-                 '    }',
-                 '  ],',
-                 '  "image": {',
-                 '    "url": "ghcr.io/ssandrews/smoldyn/biosimulators_smoldyn:latest",',
-                 '    "format": {',
-                 '      "namespace": "EDAM",',
-                 '      "id": "format_3973",',
-                 '      "version": null,',
-                 '      "supportedFeatures": []',
-                 '    },',
-                 '    "operatingSystemType": "Linux"',
-                 '  },',
-                 '  "cli": {',
-                 '    "packageRepository": "PyPI",',
-                 '    "package": "smoldyn",',
-                 '    "command": "python -m smoldyn.biosimulators",',
-                 '    "installationInstructions": null',
-                 '  },',
-                 '  "pythonApi": {',
-                 '    "package": "smoldyn",',
-                 '    "module": "smoldyn.biosimulators",',
-                 '    "installationInstructions": null',
-                 '  },',
-                 '  "authors": [{',
-                 '      "middleName": "S.",',
-                 '      "firstName": "Steven",',
-                 '      "lastName": "Andrews",',
-                 '      "identifiers": [{',
-                 '        "namespace": "orcid",',
-                 '        "id": "0000-0002-4576-8107",',
-                 '        "url": "https://orcid.org/0000-0002-4576-8107"',
-                 '      }]',
-                 '    },',
-                 '    {',
-                 '      "middleName": null,',
-                 '      "firstName": "Dilawar",',
-                 '      "lastName": "Singh",',
-                 '      "identifiers": [{',
-                 '        "namespace": "orcid",',
-                 '        "id": "0000-0002-4645-3211",',
-                 '        "url": "https://orcid.org/0000-0002-4645-3211"',
-                 '      }]',
-                 '    }',
-                 '  ],',
-                 '  "references": {',
-                 '    "identifiers": [{',
-                 '        "namespace": "pypi",',
-                 '        "id": "smoldyn",',
-                 '        "url": "https://pypi.org/project/smoldyn/"',
-                 '      },',
-                 '      {',
-                 '        "namespace": "bio.tools",',
-                 '        "id": "smoldyn",',
-                 '        "url": "https://bio.tools/smoldyn"',
-                 '      }',
-                 '    ],',
-                 '    "citations": [{',
-                 '        "volume": "33",',
-                 '        "issue": "5",',
-                 '        "pages": "710-717",',
-                 '        "journal": "Bioinformatics",',
-                 ... 274 more items
-               ],
-               stylingDirectives: [
-                 [],      [Array], [Array], [Array], [Array], [Array], [Array],
-                 [Array], [Array], [],      [],      [Array], [Array], [Array],
-                 [],      [],      [Array], [Array], [Array], [],      [],
-                 [Array], [Array], [Array], [],      [],      [Array], [Array],
-                 [Array], [],      [],      [Array], [Array], [Array], [],
-                 [],      [Array], [Array], [Array], [],      [],      [Array],
-                 [Array], [Array], [Array], [Array], [Array], [Array], [],
-                 [Array], [],      [Array], [Array], [Array], [Array], [Array],
-                 [],      [Array], [Array], [Array], [Array], [],      [Array],
-                 [Array], [Array], [Array], [Array], [Array], [Array], [Array],
-                 [],      [],      [],      [Array], [Array], [Array], [Array],
-                 [Array], [Array], [Array], [],      [],      [],      [Array],
-                 [Array], [Array], [Array], [Array], [],      [],      [Array],
-                 [Array], [Array], [],      [],      [Array], [Array], [Array],
-                 [Array], [Array],
-                 ... 274 more items
-               ],
-               csv: null,
-               csvError: null,
-               dependabotInfo: {
-                 showConfigurationBanner: false,
-                 configFilePath: null,
-                 networkDependabotPath: '/ssandrews/Smoldyn/network/updates',
-                 dismissConfigurationNoticePath: '/settings/dismiss-notice/dependabot_configuration_notice',
-                 configurationNoticeDismissed: null,
-                 repoAlertsPath: '/ssandrews/Smoldyn/security/dependabot',
-                 repoSecurityAndAnalysisPath: '/ssandrews/Smoldyn/settings/security_analysis',
-                 repoOwnerIsOrg: false,
-                 currentUserCanAdminRepo: false
-               },
-               displayName: 'biosimulators.json',
-               displayUrl: 'https://github.com/ssandrews/Smoldyn/blob/master/biosimulators.json?raw=true',
-               headerInfo: {
-                 blobSize: '16.4 KB',
-                 deleteInfo: [Object],
-                 editInfo: [Object],
-                 ghDesktopPath: 'https://desktop.github.com',
-                 gitLfsPath: null,
-                 onBranch: true,
-                 shortPath: '7caa1a6',
-                 siteNavLoginPath: '/login?return_to=https%3A%2F%2Fgithub.com%2Fssandrews%2FSmoldyn%2Fblob%2Fmaster%2Fbiosimulators.json',
-                 isCSV: false,
-                 isRichtext: false,
-                 toc: null,
-                 lineInfo: [Object],
-                 mode: 'file'
-               },
-               image: false,
-               isCodeownersFile: null,
-               isPlain: false,
-               isValidLegacyIssueTemplate: false,
-               issueTemplateHelpUrl: 'https://docs.github.com/articles/about-issue-and-pull-request-templates',
-               issueTemplate: null,
-               discussionTemplate: null,
-               language: 'JSON',
-               languageID: 174,
-               large: false,
-               loggedIn: false,
-               newDiscussionPath: '/ssandrews/Smoldyn/discussions/new',
-               newIssuePath: '/ssandrews/Smoldyn/issues/new',
-               planSupportInfo: {
-                 repoIsFork: null,
-                 repoOwnedByCurrentUser: null,
-                 requestFullPath: '/ssandrews/Smoldyn/blob/master/biosimulators.json',
-                 showFreeOrgGatedFeatureMessage: null,
-                 showPlanSupportBanner: null,
-                 upgradeDataAttributes: null,
-                 upgradePath: null
-               },
-               publishBannersInfo: {
-                 dismissActionNoticePath: '/settings/dismiss-notice/publish_action_from_dockerfile',
-                 releasePath: '/ssandrews/Smoldyn/releases/new?marketplace=true',
-                 showPublishActionBanner: false
-               },
-               rawBlobUrl: 'https://github.com/ssandrews/Smoldyn/raw/master/biosimulators.json',
-               renderImageOrRaw: false,
-               richText: null,
-               renderedFileInfo: null,
-               shortPath: null,
-               symbolsEnabled: true,
-               tabSize: 8,
-               topBannersInfo: {
-                 overridingGlobalFundingFile: false,
-                 globalPreferredFundingPath: null,
-                 repoOwner: 'ssandrews',
-                 repoName: 'Smoldyn',
-                 showInvalidCitationWarning: false,
-                 citationHelpUrl: 'https://docs.github.com/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/about-citation-files',
-                 showDependabotConfigurationBanner: false,
-                 actionsOnboardingTip: null
-               },
-               truncated: false,
-               viewable: true,
-               workflowRedirectUrl: null,
-               symbols: { timed_out: false, not_analyzed: true, symbols: [] }
-             },
-             copilotInfo: null,
-             copilotAccessAllowed: false,
-             csrf_tokens: {
-               '/ssandrews/Smoldyn/branches': {
-                 post: 'dBX8vokQKGdyold8alXxKIHSCQmwahrnowi3skDvJDuLjxtnFifE_JHyZJ_hhd7I_ic5AjXIjDV_m0DVh4n-eA'
-               },
-               '/repos/preferences': {
-                 post: '1cOIHYGWHAy--BX_qVbYbxfs6KQ0R-sfQZku8VH8ZskCK76YtvHtuFPaNKkWI5TdYdhbeerJZN_A_mlHRPNvtQ'
-               }
-             }
-           }
-       
-         Error(s):
-           - whitelistValidation: property payload should not exist
-       
-       Property 'title' is invalid.
-       
-         Value:
-           'Smoldyn/biosimulators.json at master · ssandrews/Smoldyn'
-       
-         Error(s):
-           - whitelistValidation: property title should not exist
-       
-       Property 'id' is invalid.
-       
-         Value:
-           undefined
-       
-         Error(s):
-           - isNotEmpty: id should not be empty
-           - isString: id must be a string
-       
-       Property 'name' is invalid.
-       
-         Value:
-           undefined
-       
-         Error(s):
-           - isNotEmpty: name should not be empty
-           - isString: name must be a string
-       
-       Property 'version' is invalid.
-       
-         Value:
-           undefined
-       
-         Error(s):
-           - isNotEmpty: version should not be empty
-           - isString: version must be a string
-       
-       Property 'description' is invalid.
-       
-         Value:
-           undefined
-       
-         Error(s):
-           - isNotEmpty: description should not be empty
-           - isString: description must be a string
-       
-       Property 'urls' is invalid.
-       
-         Value:
-           undefined
-       
-         Error(s):
-           - isArray: urls must be an array
-       
-       Property 'algorithms' is invalid.
-       
-         Value:
-           undefined
-       
-         Error(s):
-           - arrayUnique: Two or more algorithms have the same KiSAO id. Each algorithm must have a unique KiSAO id.
-       
-       Property 'interfaceTypes' is invalid.
-       
-         Value:
-           undefined
-       
-         Error(s):
-           - isEnum: each value in interfaceTypes must be one of the following values: library, command-line application, desktop application, mobile application, web service, web application, BioSimulators Docker image
-       
-       Property 'supportedOperatingSystemTypes' is invalid.
-       
-         Value:
-           undefined
-       
-         Error(s):
-           - isEnum: each value in supportedOperatingSystemTypes must be one of the following values: Linux, Mac OS, Windows, Unix, platform-independent

The complete log of your validation/submission job, including further information about the failure, is available for 90 days here.

If you chose to validate your Docker image, the results of the validation of your image will be available shortly as a JSON file. A link to this file will be available for 90 days from the "Artifacts" section at the bottom of this page.

Once you have fixed the problem, edit the first block of this issue to re-initiate this validation.

The BioSimulators Team is happy to help. Questions and feedback can be directed to the BioSimulators Team by posting comments to this issues that reference the GitHub team @biosimulators/biosimulators (without the backticks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Invalid This doesn't seem right Validate/submit simulator Validate a simulation tool or request its submission to the BioSimulators registry
Development

No branches or pull requests

2 participants