From 9a74ea7ca742ecfcf8ef8c6d93e7fcff802acae6 Mon Sep 17 00:00:00 2001 From: nostrbuddha Date: Mon, 3 Feb 2025 14:36:10 +0530 Subject: [PATCH] - Cleanup --- .../mobile/client/service/settings/SettingsApiGateway.kt | 6 ------ .../mobile/presentation/ui/components/atoms/TextField.kt | 8 ++++++-- .../ui/uicases/settings/GeneralSettingsScreen.kt | 2 +- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/shared/domain/src/commonMain/kotlin/network/bisq/mobile/client/service/settings/SettingsApiGateway.kt b/shared/domain/src/commonMain/kotlin/network/bisq/mobile/client/service/settings/SettingsApiGateway.kt index d7888274..405d1bda 100644 --- a/shared/domain/src/commonMain/kotlin/network/bisq/mobile/client/service/settings/SettingsApiGateway.kt +++ b/shared/domain/src/commonMain/kotlin/network/bisq/mobile/client/service/settings/SettingsApiGateway.kt @@ -73,11 +73,5 @@ class SettingsApiGateway( ) } - suspend fun setSelectedMarket(value: MarketVO): Result { - return webSocketApiClient.patch( - basePath, - SettingsChangeRequest(selectedMarket = value) - ) - } } diff --git a/shared/presentation/src/commonMain/kotlin/network/bisq/mobile/presentation/ui/components/atoms/TextField.kt b/shared/presentation/src/commonMain/kotlin/network/bisq/mobile/presentation/ui/components/atoms/TextField.kt index 8c9d19c3..70ca4579 100644 --- a/shared/presentation/src/commonMain/kotlin/network/bisq/mobile/presentation/ui/components/atoms/TextField.kt +++ b/shared/presentation/src/commonMain/kotlin/network/bisq/mobile/presentation/ui/components/atoms/TextField.kt @@ -105,9 +105,13 @@ fun BisqTextField( ) } + var hasInitialized by remember { mutableStateOf(false) } LaunchedEffect(value) { - validationError = validation?.invoke(value) - onValueChange(value, validationError == null) + if (hasInitialized) { + validationError = validation?.invoke(value) + onValueChange(value, validationError == null) + } + hasInitialized = true } Column(modifier = modifier) { diff --git a/shared/presentation/src/commonMain/kotlin/network/bisq/mobile/presentation/ui/uicases/settings/GeneralSettingsScreen.kt b/shared/presentation/src/commonMain/kotlin/network/bisq/mobile/presentation/ui/uicases/settings/GeneralSettingsScreen.kt index 68c4ccb4..ffa865ff 100644 --- a/shared/presentation/src/commonMain/kotlin/network/bisq/mobile/presentation/ui/uicases/settings/GeneralSettingsScreen.kt +++ b/shared/presentation/src/commonMain/kotlin/network/bisq/mobile/presentation/ui/uicases/settings/GeneralSettingsScreen.kt @@ -123,7 +123,7 @@ fun GeneralSettingsScreen(showBackNavigation: Boolean = false) { ) BisqTextField( - label = "settings.trade.maxTradePriceDeviation".i18n(), + label = "settings.trade.maxTradePriceDeviation".i18n() + " (TODO in androidNode)", value = tradePriceTolerance.toString(), valueSuffix = "%", keyboardType = KeyboardType.Decimal,