Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Validations Support #154

Open
rodvar opened this issue Jan 12, 2025 · 3 comments
Open

UI Validations Support #154

rodvar opened this issue Jan 12, 2025 · 3 comments
Assignees
@nostrbuddha
Labels
In Progress UI
Milestone
MVP (version 0.1.0)

Comments

@rodvar
Copy link
Collaborator

rodvar commented Jan 12, 2025 •
edited
Loading

  • error handling: textfields need to have error message and validator support as well as a default error popup
  • use this support for obvious cases and apply to the setup trusted node and trading UI
  • refactor: the various button styles should have a easy to reuse method. i guess ButtonType is the way how its intended but it has not all the diff. styles we use in bisq 2.
  • review the bisq2 definitions to check if our bisq-mobile colors match and do any necessary adaptations
@rodvar rodvar added this to the MVP (version 0.1.0) milestone Jan 12, 2025
@rodvar
Copy link
Collaborator Author

rodvar commented Jan 12, 2025

@nostrbuddha

@nostrbuddha
Copy link
Contributor

Yes. Pls assign this to me.

@nostrbuddha nostrbuddha mentioned this issue Jan 29, 2025
Merged
@rodvar
Copy link
Collaborator Author

rodvar commented Feb 4, 2025

Support with an example has been implemented, just need to apply the solution in all the user inputs with the corresponding validations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nostrbuddha nostrbuddha

Labels
In Progress UI
Projects
None yet
Milestone
MVP (version 0.1.0)
Development

No branches or pull requests
2 participants
@rodvar @nostrbuddha