Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a !rq similar to how Limnoria does it #363

Open
NetSysFire opened this issue May 17, 2023 · 2 comments
Open

Implement a !rq similar to how Limnoria does it #363

NetSysFire opened this issue May 17, 2023 · 2 comments

Comments

@NetSysFire
Copy link

@examknow specifically asked me on IRC to report this one. "!rq" stands for random quote in Limnoria.

Steps to reproduce

  1. Be in a fun channel.
  2. Try to make the bot emit a random quote that was grabbed in this channel.
  3. ,quote on its own requires an argument and ,quote <#channel> will return [Quotes] No matching quotes
  4. Be sad.

Expected behavior

,quote on its own would emit a random quote grabbed in this channel or namespace.

Make the latter one configurable perhaps. In e.g a fictional ontopic "#linux" channel, you'd want a random quote to only consist of ones grabbed in that channel, not the potentially inappropriate ones from e.g the offtopic channel. "#linux-offtopic" however would be just fine with any public quotes from the entire #linux-* namespace.

@examknow
Copy link
Member

I think we should limit random quotes to inside a single channel context. If nothing else, this will avoid accidental exposure of private data to public channels.

@examknow
Copy link
Member

Perhaps the channel-quotes settings should also be defaulted to on for the same reason

cc @jesopo - thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants