Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added campfire games images, description, and background #20

Closed
wants to merge 2 commits into from

Conversation

Joanne-Lee20
Copy link
Collaborator

image
image

@Joanne-Lee20 Joanne-Lee20 linked an issue Jan 13, 2025 that may be closed by this pull request
@Joanne-Lee20
Copy link
Collaborator Author

  • Added/positioned images and updated description for Campfire Games section
  • Used media breakpoints to account for responsiveness (will adjust when uniform breakpoint is decided)
  • Added background but might need to wait for other sections to be completed in order to ensure positioning is seamless

@Joanne-Lee20 Joanne-Lee20 self-assigned this Jan 13, 2025
@SPTLAbron
Copy link
Contributor

It looks perfect Joann. Just a few administrative changes:

  1. Can you change the name of the branch to campfire_games_joanne?
  2. Can you push to dev instead of main? Some changes will need to be made once the dinosaurs are completed. Therefore, it would be easier to push your changes to dev and instruct your pair on their coinciding task before pushing the entire component to main. You shouldn't have any restrictions to push to dev.

Again, great work and thank you for working through break.

@Joanne-Lee20 Joanne-Lee20 deleted the campfire-games branch January 15, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Campfire Games
2 participants