Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples should not retry on bad randomness keys in a loop #1570

Closed
real-or-random opened this issue Jul 12, 2024 · 1 comment
Closed

Examples should not retry on bad randomness keys in a loop #1570

real-or-random opened this issue Jul 12, 2024 · 1 comment
Labels
good first issue refactor/smell user-documentation user-facing documentation

Comments

@real-or-random
Copy link
Contributor

Well, we should change the other examples and perhaps also the API docs. Creating keys in a while loop is not good practice. If you hit an invalid key, you're most probably not very lucky, but very unlucky because your randomness is broken. But hey, yeah, let's just yolo and try again. :)

Originally posted by @real-or-random in #1519 (comment)
@real-or-random real-or-random mentioned this issue Jul 12, 2024
Open
3 tasks
@josibake josibake mentioned this issue Jul 25, 2024
Merged
This was referenced Aug 29, 2024
Closed
Merged
jonasnick added a commit that referenced this issue Oct 13, 2024
@jonasnick
Merge #1599: #1570 improve examples: remove key generation loop
01b5893 
cd4f84f Improve examples/documentation: remove key generation loops (cheapshot003)

Pull request description:

ACKs for top commit:
  real-or-random:
    utACK cd4f84f
  jonasnick:
    ACK cd4f84f

Tree-SHA512: 242ab99c36302b539fc95421142c3eec5ccfa2cf918989457886338febde45a33b1794e0f08e7a632747bc21cbf5c47b7361fd9a28b9a1c6dff7caecf7b31a9f
@jonasnick jonasnick mentioned this issue Oct 14, 2024
Merged
real-or-random added a commit that referenced this issue Oct 14, 2024
@real-or-random
Merge #1616: examples: do not retry generating seckey randomness in m…
18f9b96 
…usig

5bab8f6 examples: make key generation doc consistent (Jonas Nick)
e890822 examples: do not retry generating seckey randomness in musig (Jonas Nick)
70b6be1 extrakeys: improve doc of keypair_create (don't suggest retry) (Jonas Nick)

Pull request description:

  Follow-up to #1570.

ACKs for top commit:
  real-or-random:
    utACK 5bab8f6
  theStack:
    ACK 5bab8f6

Tree-SHA512: f29ceda87b0017aa2a2324f23527467c777223c9f7cbe43d814bb1cebfc6f4453b7e11f48a6bc718ae05d7eb9227ceb074adf576e8bb8c28639b47931136ce0a
@real-or-random
Copy link
Contributor Author

Resolved by #1570 and #1616.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue refactor/smell user-documentation user-facing documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@real-or-random