[bitnami/external-dns] chart adds podLabels to all resources and can cause duplicates

[pinkfloydx33]

Name and Version

bitnami/external-dns 6.13.1

What steps will reproduce the bug?

Specify any labels in values.podLabels

Are you using any custom parameters or values?

No response

What is the expected behavior?

podLabels should only be added to Pods (via Deployment spec.template.metadata.labels)

What do you see instead?

Pod Labels are treated as "common" labels and when any exist are added to ALL resources (ServiceAccount, Deployment, Cluster Role, etc.)

Additional information

While obviously incorrect, this caused an issue for us during deployment as we have a label that must be specified for both ServiceAccount and Pods. As such, we added the label to both podLabels and serviceAccount.labels. Because they are treated as "common", a duplicate label was added to the ServiceAccount, causing helm to error during deployment

It's due to lines 40-42 here:

charts/bitnami/external-dns/templates/_helpers.tpl

Lines 34 to 42 in f64c2cc

	{{/* Helm required labels */}}
	{{- define "external-dns.labels" -}}
	app.kubernetes.io/name: {{ template "external-dns.name" . }}
	helm.sh/chart: {{ template "external-dns.chart" . }}
	app.kubernetes.io/instance: {{ .Release.Name }}
	app.kubernetes.io/managed-by: {{ .Release.Service }}
	{{- if .Values.podLabels }}
	{{ toYaml .Values.podLabels }}
	{{- end }}

The inclusion in external-dns.labels causes the labels to be propogated to all resources, since they all call that template.

Note that this chart already has a commonLabels which is probably what should be in the block above instead:

charts/bitnami/external-dns/values.yaml

Line 33 in f64c2cc

commonLabels: {}

(however output of commonLabels appears in all the manifest templates individually, not as part of the helper)

The fix is to remove the podLabels from the external-dns.labels template and to incorporate them directly into the Deployment manifest, similar to other labels and annotations

[javsalgar]

Hi,

Thank you so much for reporting. Would you like to submit a PR fixing the issue?

[github-actions]

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

[pinkfloydx33]

@javsalgar Sorry for the delayed response. I have been real busy and don't have time to submit a PR right now. I'm also not sure what the appropriate fix would be as I believe the labels are all messed up in general. I think it needs a bit of a rework, but I'm not an expert on these charts....