[bitnami/keycloak] Update KEYCLOAK_ADMIN env variable for deprecation #30635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environment variable 'KEYCLOAK_ADMIN' is deprecated, use 'KC_BOOTSTRAP_ADMIN_USERNAME' instead Environment variable 'KEYCLOAK_ADMIN_PASSWORD' is deprecated, use 'KC_BOOTSTRAP_ADMIN_PASSWORD' instead
singatias
changed the title
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Environment variable 'KEYCLOAK_ADMIN' is deprecated, use 'KC_BOOTSTRAP_ADMIN_USERNAME' instead Environment variable 'KEYCLOAK_ADMIN_PASSWORD' is deprecated, use 'KC_BOOTSTRAP_ADMIN_PASSWORD' instead Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
…tps://github.com/singatias/charts into feature/keycloak-admin-deprecation-warning-patch
Signed-off-by: Bitnami Containers <[email protected]>
Environment variable 'KEYCLOAK_ADMIN' is deprecated, use 'KC_BOOTSTRAP_ADMIN_USERNAME' instead Environment variable 'KEYCLOAK_ADMIN_PASSWORD' is deprecated, use 'KC_BOOTSTRAP_ADMIN_PASSWORD' instead Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
…mi#30624) Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
* [bitnami/kube-prometheus] Add support for scrapeClasses Signed-off-by: David Hedberg <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: David Hedberg <[email protected]> Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Juan José Martos <[email protected]> Co-authored-by: Bitnami Containers <[email protected]> Co-authored-by: Juan José Martos <[email protected]> Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
* [bitnami/thanos] Release 15.8.2 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
Signed-off-by: juan131 <[email protected]> Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
* [bitnami/haproxy] Release 2.1.11 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
* [bitnami/chainloop] Release 2.0.43 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
* [bitnami/nginx] Release 18.2.6 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
* [bitnami/clickhouse] Release 7.0.2 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
* [bitnami/chainloop] Release 2.0.44 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
Environment variable 'KEYCLOAK_ADMIN' is deprecated, use 'KC_BOOTSTRAP_ADMIN_USERNAME' instead Environment variable 'KEYCLOAK_ADMIN_PASSWORD' is deprecated, use 'KC_BOOTSTRAP_ADMIN_PASSWORD' instead Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Mathias Beaulieu-Duncan <[email protected]>
…tps://github.com/singatias/charts into feature/keycloak-admin-deprecation-warning-patch
|
I'm not sure what I am doing wrong to respect the DCO requirement and the amount of commits are starting to grow exponentially, what should I do? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Minor changes to change KEYCLOAK_ADMIN and KEYCLOAK_ADMIN_PASSWORD environment and secret variables to update to the new values KC_BOOTSTRAP_ADMIN_USERNAME, KC_BOOTSTRAP_ADMIN_PASSWORD
Benefits
remove deprecation message and reduce the upcoming maintenance when the env variables will be removed
Possible drawbacks
the new variables env could be invalid on a an older keycloak image
Applicable issues
none
Additional information
I notice the deprecation messages on my new instance of keycloak and decided to make the changes since they were minor
I could be wrong about bumping the major version of the chart, but technically, if someone upgrades their Keycloak instance using an older overridden version of the Keycloak image from before the environment variables were changed, it could be defective. Let me know if this need to be change or feel free to edit it before merging.
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm