From 865f2d8a9aa4a8da1ce0d3e191e413ca3164085a Mon Sep 17 00:00:00 2001 From: sajjad Date: Fri, 15 Nov 2024 11:58:20 +0330 Subject: [PATCH 1/5] Feat(redis-cluster): set custom terminationGracePeriodSeconds for redis Signed-off-by: Sajad Sadrayieh --- bitnami/redis-cluster/Chart.yaml | 2 +- bitnami/redis-cluster/templates/redis-statefulset.yaml | 3 +++ bitnami/redis-cluster/values.yaml | 7 +++++++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/bitnami/redis-cluster/Chart.yaml b/bitnami/redis-cluster/Chart.yaml index 4b30ab22c062a7..22a3411d753572 100644 --- a/bitnami/redis-cluster/Chart.yaml +++ b/bitnami/redis-cluster/Chart.yaml @@ -32,4 +32,4 @@ maintainers: name: redis-cluster sources: - https://github.com/bitnami/charts/tree/main/bitnami/redis-cluster -version: 11.0.8 +version: 11.1.0 diff --git a/bitnami/redis-cluster/templates/redis-statefulset.yaml b/bitnami/redis-cluster/templates/redis-statefulset.yaml index 522c35953197c3..223a963364ae04 100644 --- a/bitnami/redis-cluster/templates/redis-statefulset.yaml +++ b/bitnami/redis-cluster/templates/redis-statefulset.yaml @@ -75,6 +75,9 @@ spec: {{- if .Values.redis.shareProcessNamespace }} shareProcessNamespace: {{ .Values.redis.shareProcessNamespace }} {{- end }} + {{- if .Values.redis.terminationGracePeriodSeconds }} + terminationGracePeriodSeconds: {{ .Values.redis.terminationGracePeriodSeconds }} + {{- end }} {{- if .Values.redis.schedulerName }} schedulerName: {{ .Values.redis.schedulerName | quote }} {{- end }} diff --git a/bitnami/redis-cluster/values.yaml b/bitnami/redis-cluster/values.yaml index 6c27da4f3f0685..22b2ff425499cf 100644 --- a/bitnami/redis-cluster/values.yaml +++ b/bitnami/redis-cluster/values.yaml @@ -609,6 +609,13 @@ redis: ## Ref: https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace/ ## shareProcessNamespace: false + ## @param redis.terminationGracePeriodSeconds Set custom gracefull termination period for redis container. + ## If not set the kubernetes default will be applied. + ## Customize it based on your workload. Huge redis with high load may wants more than default time to dump + ## their data before complete termination. + ## Ref: https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/#hook-handler-execution + ## + terminationGracePeriodSeconds: 30 ## Configure extra options for Redis® liveness probes ## ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/#configure-probes) ## @param redis.livenessProbe.enabled Enable livenessProbe From 2dbb2cd34e1f31559508d7f6e850293ecd58a0a3 Mon Sep 17 00:00:00 2001 From: Bitnami Containers Date: Sun, 24 Nov 2024 09:10:37 +0000 Subject: [PATCH 2/5] Update CHANGELOG.md Signed-off-by: Bitnami Containers --- bitnami/redis-cluster/CHANGELOG.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/bitnami/redis-cluster/CHANGELOG.md b/bitnami/redis-cluster/CHANGELOG.md index c1bf73c95716d4..f30319bab28a36 100644 --- a/bitnami/redis-cluster/CHANGELOG.md +++ b/bitnami/redis-cluster/CHANGELOG.md @@ -1,8 +1,12 @@ # Changelog -## 11.0.8 (2024-11-11) +## 11.1.0 (2024-11-24) -* [bitnami/redis-cluster] Release 11.0.8 ([#30406](https://github.com/bitnami/charts/pull/30406)) +* feat(redis-cluster): Set custom terminationGracePeriodSeconds for redis ([#30470](https://github.com/bitnami/charts/pull/30470)) + +## 11.0.8 (2024-11-11) + +* [bitnami/redis-cluster] Release 11.0.8 (#30406) ([03bdf29](https://github.com/bitnami/charts/commit/03bdf29b58fb4f1d4d9561d7654d39fc5e8e7ffd)), closes [#30406](https://github.com/bitnami/charts/issues/30406) ## 11.0.7 (2024-11-08) From 4ab9479097fdfed1708609c2619f6cf4731ea795 Mon Sep 17 00:00:00 2001 From: Bitnami Containers Date: Sun, 24 Nov 2024 09:10:40 +0000 Subject: [PATCH 3/5] Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers --- bitnami/redis-cluster/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/bitnami/redis-cluster/README.md b/bitnami/redis-cluster/README.md index 06338725d7ea13..26a0bbe69f9238 100644 --- a/bitnami/redis-cluster/README.md +++ b/bitnami/redis-cluster/README.md @@ -522,6 +522,7 @@ See [#15075](https://github.com/bitnami/charts/issues/15075) | `redis.resources` | Set container requests and limits for different resources like CPU or memory (essential for production workloads) | `{}` | | `redis.schedulerName` | Use an alternate scheduler, e.g. "stork". | `""` | | `redis.shareProcessNamespace` | Enable shared process namespace in a pod. | `false` | +| `redis.terminationGracePeriodSeconds` | Set custom gracefull termination period for redis container. | `30` | | `redis.livenessProbe.enabled` | Enable livenessProbe | `true` | | `redis.livenessProbe.initialDelaySeconds` | Initial delay seconds for livenessProbe | `5` | | `redis.livenessProbe.periodSeconds` | Period seconds for livenessProbe | `5` | From cd1ffa33888ec61db55858407762a9f5c7a385b1 Mon Sep 17 00:00:00 2001 From: Bitnami Containers Date: Mon, 25 Nov 2024 08:15:22 +0000 Subject: [PATCH 4/5] Update CHANGELOG.md Signed-off-by: Bitnami Containers --- bitnami/redis-cluster/CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bitnami/redis-cluster/CHANGELOG.md b/bitnami/redis-cluster/CHANGELOG.md index f30319bab28a36..4916536826f1c2 100644 --- a/bitnami/redis-cluster/CHANGELOG.md +++ b/bitnami/redis-cluster/CHANGELOG.md @@ -1,8 +1,8 @@ # Changelog -## 11.1.0 (2024-11-24) +## 11.1.0 (2024-11-25) -* feat(redis-cluster): Set custom terminationGracePeriodSeconds for redis ([#30470](https://github.com/bitnami/charts/pull/30470)) +* [bitnami/redis-cluster] feat: Set custom terminationGracePeriodSeconds for redis ([#30470](https://github.com/bitnami/charts/pull/30470)) ## 11.0.8 (2024-11-11) From f522d5988abbb25398477bb62d0f9d4193237513 Mon Sep 17 00:00:00 2001 From: Bitnami Containers Date: Tue, 26 Nov 2024 08:37:50 +0000 Subject: [PATCH 5/5] Update CHANGELOG.md Signed-off-by: Bitnami Containers --- bitnami/redis-cluster/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bitnami/redis-cluster/CHANGELOG.md b/bitnami/redis-cluster/CHANGELOG.md index 4916536826f1c2..9f60c63532544d 100644 --- a/bitnami/redis-cluster/CHANGELOG.md +++ b/bitnami/redis-cluster/CHANGELOG.md @@ -1,6 +1,6 @@ # Changelog -## 11.1.0 (2024-11-25) +## 11.1.0 (2024-11-26) * [bitnami/redis-cluster] feat: Set custom terminationGracePeriodSeconds for redis ([#30470](https://github.com/bitnami/charts/pull/30470))