Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bit-panel shouldn't use the title attribute #15

Open
marshallswain opened this issue Apr 12, 2016 · 1 comment
Open

bit-panel shouldn't use the title attribute #15

marshallswain opened this issue Apr 12, 2016 · 1 comment

Comments

@marshallswain
Copy link
Contributor

Using the title attribute on the bit-panel causes the browser to show a tooltip any time you hover over any part of the tab's contents. This can result in a very confusing UX when the name of the tab pops up completely out of context. Maybe we can have it check for a tab-title attribute if there's not a title and do a patch or minor release?

@justinbmeyer
Copy link
Contributor

Sure, we could probably use a getter so it's backwards compat:

tabTitle: {
  get: function(lastSet){
    if(lastSet) return lastSet;
    return this.attr("title");
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants