Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3] AltStore&AltContainer has memory leak #1497

Closed
roths opened this issue May 9, 2018 · 4 comments
Closed

[3] AltStore&AltContainer has memory leak #1497

roths opened this issue May 9, 2018 · 4 comments
Assignees
@svk31
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Milestone
181017

Comments

@roths
Copy link

roths commented May 9, 2018 •
edited
Loading

AltStore&AltContainer has memory leak

AltStore problem detail in here:
goatslacker/alt#725

AltContainer problem detail in here:
altjs/container#11

alt-react have same problem with AltContainer but i dont pull request to it
@wmbutler wmbutler added the [3] Bug Classification indicating the existing implementation does not match the intention of the design label May 10, 2018
@wmbutler wmbutler modified the milestones: 180501, 180515 May 10, 2018
@wmbutler wmbutler changed the title AltStore&AltContainer has memory leak [1] AltStore&AltContainer has memory leak May 10, 2018
@wmbutler wmbutler mentioned this issue May 10, 2018
Open
@wmbutler wmbutler modified the milestones: 180525, 180605 May 29, 2018
@wmbutler wmbutler modified the milestones: 180615, 180701 Jun 20, 2018
@wmbutler wmbutler modified the milestones: 180706, 180721 Jul 9, 2018
@wmbutler wmbutler modified the milestones: 180720, 180803 Jul 23, 2018
@wmbutler wmbutler modified the milestones: 180801, 180815 Aug 6, 2018
@wmbutler wmbutler modified the milestones: 180815, 180905 Aug 26, 2018
@wmbutler wmbutler modified the milestones: 180905, 180919 Sep 13, 2018
@startailcoon
Copy link
Contributor

@svk31 is this an issue and does it require some hours to be looked at or fixed?

@wmbutler wmbutler modified the milestones: 180919, 181003 Sep 25, 2018
@wmbutler
Copy link
Contributor

@roths did you observe a problem with the wallet? If not please close.

@wmbutler wmbutler modified the milestones: 181003, 181017 Oct 5, 2018
svk31 added a commit to bitshares/alt that referenced this issue Oct 9, 2018
@svk31
Fix AltStore memleak bitshares/bitshares-ui#1497
b6b42ce
svk31 added a commit to bitshares/alt-container that referenced this issue Oct 9, 2018
@svk31
Fix memleak
62570bf 
bitshares/bitshares-ui#1497
svk31 added a commit to bitshares/alt-react that referenced this issue Oct 9, 2018
@svk31
Fix memleak
1cb615d 
bitshares/bitshares-ui#1497
@svk31 svk31 changed the title [1] AltStore&AltContainer has memory leak [3] AltStore&AltContainer has memory leak Oct 9, 2018
@svk31 svk31 closed this as completed in db62e9f Oct 10, 2018
@svk31
Copy link
Contributor

svk31 commented Oct 10, 2018

@roths Thanks for reporting this, you were indeed correct and all three libraries had major memory leaks in the subscription arrays, which in our case were probably quite serious since we have so many components making use of them!

@clockworkgr
Copy link
Member

sweet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svk31 svk31

Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Projects
None yet
Milestone
181017
Development

No branches or pull requests
5 participants
@wmbutler @clockworkgr @svk31 @roths @startailcoon