Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring package name #1

Open
cuonglm opened this issue May 22, 2020 · 2 comments
Open

Refactoring package name #1

cuonglm opened this issue May 22, 2020 · 2 comments
Assignees
@greatbn

Comments

@cuonglm
Copy link

cuonglm commented May 22, 2020

Package name common is considered bad practice in Go, do not use it.

See: https://blog.golang.org/package-names
@greatbn
Copy link
Contributor

greatbn commented May 22, 2020

Thank for your recommendation, I will refactor that package name.

@greatbn greatbn closed this as completed May 24, 2020
@cuonglm
Copy link
Author

cuonglm commented May 25, 2020

@greatbn Please don't close issue unconditionally.

Make a PR and go through code review process.

@greatbn greatbn reopened this May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatbn greatbn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cuonglm @greatbn