From 0bad1de771e6cb67c284c7dc13f763b5724fa2c4 Mon Sep 17 00:00:00 2001
From: Brage Sekse Aarset <brage.aarset@gmail.com>
Date: Fri, 8 Sep 2023 15:42:11 +0300
Subject: [PATCH] fix: make customer and department nullable, add realistic
 sample data in test (#113)

* fix: make customer and department nullable

* test: update test
---
 src/calls/contact/__tests__/contact.test.ts | 60 ++++++++++-----------
 src/calls/contact/models/contact.ts         |  4 +-
 2 files changed, 29 insertions(+), 35 deletions(-)

diff --git a/src/calls/contact/__tests__/contact.test.ts b/src/calls/contact/__tests__/contact.test.ts
index 4633c81..d287447 100644
--- a/src/calls/contact/__tests__/contact.test.ts
+++ b/src/calls/contact/__tests__/contact.test.ts
@@ -24,29 +24,26 @@ describe('activity class', () => {
         versionDigest: 'Checksum not yet supported for this endpoint',
         values: [
           {
-            id: 1734852,
-            version: 1,
-            url: 'api.tripletex.io/v2/contact/1734852',
-            firstName: 'Simen A. W. Olsen',
-            lastName: 'API Testuser',
-            displayName: 'Simen A. W. Olsen API Testuser',
-            email: 'an@email.co.uk',
-            phoneNumberMobileCountry: {
-              id: 161,
-              url: 'api.tripletex.io/v2/country/161',
+            "id" : 9004148,
+            "version" : 1,
+            "url" : "tripletex.no/v2/contact/88885",
+            "firstName" : "Fastprisavtale",
+            "lastName" : "",
+            "displayName" : "Fastprisavtale",
+            "email" : "",
+            "phoneNumberMobileCountry" : {
+              "id" : 161,
+              "url" : "tripletex.no/v2/country/161"
             },
-            phoneNumberMobile: '',
-            phoneNumberWork: '',
-            customer: {
-              id: 88885,
-              url: 'api.tripletex.io/v2/customer/88885',
+            "phoneNumberMobile" : "",
+            "phoneNumberWork" : "",
+            "customer" : null,
+            "department" : {
+              "id" : 88885,
+              "url" : "tripletex.no/v2/department/88885"
             },
-            department: {
-              id: 88885,
-              url: 'api.tripletex.io/v2/department/88885',
-            },
-            isInactive: false,
-          },
+            "isInactive" : false
+          }
         ],
       });
     const entries = await client.list();
@@ -56,27 +53,24 @@ describe('activity class', () => {
     expect(entries.body.values).toMatchInlineSnapshot(`
 Array [
   Object {
-    "customer": Object {
-      "id": 88885,
-      "url": "api.tripletex.io/v2/customer/88885",
-    },
+    "customer": null,
     "department": Object {
       "id": 88885,
-      "url": "api.tripletex.io/v2/department/88885",
+      "url": "tripletex.no/v2/department/88885",
     },
-    "displayName": "Simen A. W. Olsen API Testuser",
-    "email": "an@email.co.uk",
-    "firstName": "Simen A. W. Olsen",
-    "id": 1734852,
+    "displayName": "Fastprisavtale",
+    "email": "",
+    "firstName": "Fastprisavtale",
+    "id": 9004148,
     "isInactive": false,
-    "lastName": "API Testuser",
+    "lastName": "",
     "phoneNumberMobile": "",
     "phoneNumberMobileCountry": Object {
       "id": 161,
-      "url": "api.tripletex.io/v2/country/161",
+      "url": "tripletex.no/v2/country/161",
     },
     "phoneNumberWork": "",
-    "url": "api.tripletex.io/v2/contact/1734852",
+    "url": "tripletex.no/v2/contact/88885",
     "version": 1,
   },
 ]
diff --git a/src/calls/contact/models/contact.ts b/src/calls/contact/models/contact.ts
index e45e6f4..258166b 100644
--- a/src/calls/contact/models/contact.ts
+++ b/src/calls/contact/models/contact.ts
@@ -20,11 +20,11 @@ const contactRt = rt.Record({
   customer: rt.Record({
     id: rt.Number,
     url: rt.String,
-  }),
+  }).nullable(),
   department: rt.Record({
     id: rt.Number,
     url: rt.String,
-  }),
+  }).nullable(),
   isInactive: rt.Boolean.nullable().optional(),
 })