From 84ac55deadd1e161f5ae6b788dcb5bd2faac7de9 Mon Sep 17 00:00:00 2001
From: yonihemi <jonathan@hemi.dev>
Date: Mon, 7 Aug 2023 17:26:27 +0800
Subject: [PATCH] Disable bitcode by default

---
 Sources/FMake/Framework.swift | 2 +-
 Sources/FMake/Platform.swift  | 8 ++------
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/Sources/FMake/Framework.swift b/Sources/FMake/Framework.swift
index 5061982..13710bd 100644
--- a/Sources/FMake/Framework.swift
+++ b/Sources/FMake/Framework.swift
@@ -7,7 +7,7 @@ public func xbArchive(
   framework: String = "",
   platform: Platform = .iPhoneOS,
   buildForDistribution: Bool = true,
-  enableBitCode: Bool = true,
+  enableBitCode: Bool = false,
   excludedArchs: [Platform.Arch] = [],
   skipInstall: Bool = false,
   env: [String: String]? = nil
diff --git a/Sources/FMake/Platform.swift b/Sources/FMake/Platform.swift
index 2a07f62..6653f58 100644
--- a/Sources/FMake/Platform.swift
+++ b/Sources/FMake/Platform.swift
@@ -122,7 +122,7 @@ public enum Platform: String, CaseIterable {
     return ""
   }
 
-  public func ccFlags(release: Bool = true, arch: Arch, minVersion: String? = nil, bitcode: Bool = true, noCommon: Bool = false, sysroot: Bool = true) -> String {
+  public func ccFlags(release: Bool = true, arch: Arch, minVersion: String? = nil, bitcode: Bool = false, noCommon: Bool = false, sysroot: Bool = true) -> String {
     [
       release ? "-O3" : "-g -O0",
       bitcode ? "-fembed-bitcode" : "",
@@ -136,7 +136,7 @@ public enum Platform: String, CaseIterable {
     .joined(separator: " ")
   }
   
-  public func ldFlags(arch: Arch, minVersion: String? = nil, bitcode: Bool = true, syslibroot: Bool = true) -> String {
+  public func ldFlags(arch: Arch, minVersion: String? = nil, bitcode: Bool = false, syslibroot: Bool = true) -> String {
     [
       // "-arch \(arch)",
       // bitcode ? "-bitcode_bundle" : "",
@@ -256,10 +256,6 @@ public func appleCMake() -> String {
     list(APPEND CMAKE_FIND_ROOT_PATH $ENV{SECOND_FIND_ROOT_PATH})
     set(CMAKE_XCODE_ATTRIBUTE_CODE_SIGNING_REQUIRED "NO")
 
-    set(BITCODE "-fembed-bitcode")
-    set(CMAKE_XCODE_ATTRIBUTE_BITCODE_GENERATION_MODE "bitcode")
-    set(CMAKE_XCODE_ATTRIBUTE_ENABLE_BITCODE "YES")
-
     if (NOT $ENV{APPLE_PLATFORM} MATCHES "macosx")
         set(UNIX True)
         set(APPLE True)