Atproto oauth-client-node in Deno environment

[technoY2K]

Currently, I am unable to get a working example going in Deno because of the following error when calling the authorize method. I do understand that it is a deno issue which is not supporting this specific node:crypto API which I think PR 27325 is attempting to fix over in denoland.

Uncaught (in promise) Error: Not implemented: jwk private key export not implemented

This has been brought up by another user found at this issue in the atproto repo here 2866. My question is regarding whether there is a work-around or possibly some kind of configuration with the client I could try to in order to avoid this error while we wait for an official fix in deno? Is there something I could override in the atproto-oauth-client-node package or maybe just implement the oauth flow from scratch?

[knotbin]

Are you using Deno 2? I had issues with Deno support before Deno 2 but now with backwards compatibility with Node and npm, things have worked much better for me for the most part.

[technoY2K]

Hey @knotbin, OG poster of the issue, good to see ya. Yeah, I am using deno 2. There's something that its not implementing when you try to invoke the authorize function on a NodeOAuthClient instance.

[knotbin]

got it, haven't worked with this for a while so you probably know better than I do. Sorry I couldn't be of more help.

[technoY2K]

No prob. I think deno needs a few more updates. They actually did a fix for one of the issues in PR 27325. As you can see, I've been bugging them too 🤣

[callmephilip]

i've just upgraded to canary. the original error is gone and is now replaced with

JOSENotSupported: Unsupported key curve for this operation
    at namedCurveToJOSE (file:///Users/philip/Library/Caches/deno/npm/registry.npmjs.org/jose/5.9.6/dist/node/cjs/runtime/get_named_curve.js:23:19)
    at getNamedCurve (file:///Users/philip/Library/Caches/deno/npm/registry.npmjs.org/jose/5.9.6/dist/node/cjs/runtime/get_named_curve.js:55:20)
    at keyForCrypto (file:///Users/philip/Library/Caches/deno/npm/registry.npmjs.org/jose/5.9.6/dist/node/cjs/runtime/node_key.js:91:61)
    at sign (file:///Users/philip/Library/Caches/deno/npm/registry.npmjs.org/jose/5.9.6/dist/node/cjs/runtime/sign.js:17:91)
    at FlattenedSign.sign (file:///Users/philip/Library/Caches/deno/npm/registry.npmjs.org/jose/5.9.6/dist/node/cjs/jws/flattened/sign.js:71:55)
    at CompactSign.sign (file:///Users/philip/Library/Caches/deno/npm/registry.npmjs.org/jose/5.9.6/dist/node/cjs/jws/compact/sign.js:15:43)
    at SignJWT.sign (file:///Users/philip/Library/Caches/deno/npm/registry.npmjs.org/jose/5.9.6/dist/node/cjs/jwt/sign.js:22:20)
    at JoseKey.createJwt (file:///Users/philip/Library/Caches/deno/npm/registry.npmjs.org/@atproto/jwk-jose/0.1.2/dist/jose-key.js:29:14)
    at eventLoopTick (ext:core/01_core.js:175:7)
    at async OAuthServerAgent.dpopFetch (file:///Users/philip/Library/Caches/deno/npm/registry.npmjs.org/@atproto/oauth-client/0.3.5/dist/fetch-dpop.js:34:27) {
  code: "ERR_JOSE_NOT_SUPPORTED",
  name: "JOSENotSupported"
}

[callmephilip]

gonna try my luck here

[technoY2K]

Hey @callmephilip
In addition to using the canary version, I ended up using @atproto/oauth-client instead of @atproto/oauth-client-node. I also had to implement JoseKey to use the deno version of jose. I think thats where the issue lies, somewhere within the npm version of jose. I can send you what I got to make it all work.

[callmephilip]

yeah, this is what i suspected as well. would love to see what you have!

[callmephilip]

@technoY2K i think i got it to work: https://github.com/callmephilip/tinychat-at-proto/blob/main/nbs/oauth.ipynb

thanks for pointing me in the right direction!

[technoY2K]

Yup, that looks about right. I also had to do the following for getKey. Not sure if you need the same.

 protected async getKey() {
    try {
      this.jwk.key_ops = ["sign"];
      this.jwk.ext = true;

      return (this.#keyObj ||= await importJWK(this.jwk as JWK, "ES256"));
    } catch (cause) {
      throw new JwkError("Failed to import JWK", undefined, { cause });
    }
  }

[technoY2K]

key_ops and ext

[technoY2K]

Thats nice you're doing a write up @callmephilip