Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Help Menu bar entries in launched Eclipse instance during bndtools development #5853

Closed
chrisrueger opened this issue Oct 29, 2023 · 6 comments

Comments

@chrisrueger
Copy link
Contributor

For some reason when I launch bndtools from /bndtools.core/bndtools.cocoa.macosx.x86_64.bndrun the launched Eclipse instance's (Version: 2022-09 (4.25) Build id: I20220831-1800) Help menu bar looks like this.

image

Compare it to the normal Eclipse 4.29 from which I launched it:

image

I discovered during work on #5852 where I wanted to extend the Welcome Intro screen. But I cannot open the Welcome screen because the entry is missing.

Has anybody seen this behavior? @laeubi maybe?

OS: MacOS Sonoma 14.1.

@laeubi
Copy link
Contributor

laeubi commented Oct 30, 2023

I have no mac for testing but @SyntevoAlex might be the SWT mac expert, but you should probabbly also report this to the SWT project if you think its an SWT issue.

Another problem might be that your bndrun does not include everything (e.g mpc, p2, oomph) what contributes to the menu. When you have a recent PDE you can create a product file, add bndtools feature + platform sdk + marketplace should give you similar, or you create a new product run out of your workspace.

@chrisrueger
Copy link
Contributor Author

chrisrueger commented Oct 30, 2023

Another problem might be that your bndrun does not include everything (e.g mpc, p2, oomph) what contributes to the menu.

Ha you were right 😄 @laeubi

-runbundles seems to contain org.eclipse.ui.intro;version='[3.6.600,3.6.601)' but maybe not other intro-related bundles?

e.g. if I search my repo I find other bundles which are not yet part of -runbundles.

image

After I added all of them to -runbundles manually I now see the Welcome menu entry.
image

I am not sure which one it is wether it is just one or all of them.

@pkriens : What would be the best way to go forward here? Are the -runbundles maintained just manually?

@pkriens
Copy link
Member

pkriens commented Oct 30, 2023

They are maintained manually. I think @kriegfrj was working on improving this.

Can this issue be closed?

@chrisrueger
Copy link
Contributor Author

Can this issue be closed?

When you give your ok that I add this to my work in #5852 then yes, this can be closed.

@kriegfrj
Copy link
Contributor

kriegfrj commented Oct 30, 2023

They are maintained manually. I think @kriegfrj was working on improving this.

No, @bjhargrave fixed this. We use the resolver. The base set of runrequires is in the bndtools.shared.bndrun, with os-specific requirements added using the merged property feature (ie, -runrequires.win32, etc) in the os- specific bndruns that include the shared bndrun.

@chrisrueger
Copy link
Contributor Author

Thanks @kriegfrj . I added them to shared.bndrun in
2591b3a

then I ran the resolver which resulted in the following -runbundles

b05a414

I think we can close this issue here and continue in #5852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants