-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: expand predict-genes-prodigal to take SampleData[Contigs] as input #236
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 95.60% 95.29% -0.32%
==========================================
Files 34 34
Lines 1956 1997 +41
Branches 226 238 +12
==========================================
+ Hits 1870 1903 +33
- Misses 48 51 +3
- Partials 38 43 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just a small comment below. Let's wait for @pmomocabr to test it out before merging ⏳
In the meantime, could you please investigate what happened in the CI tests?
Also, could you please review the parameter/input/output descriptions in the plugin_setup.py? It seems like some of those require updating too 🙏 |
So I had a look at the CI failure. It only happens in the macos build but locally the tests run fine. The first call is the correct one: The the 4 calls after that look like this: So it looks like MacOS CI automatically deletes temporary files and is calling os.remove to do so. To solve this I will change the assertion to: What I dont understand is why is it only now a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🔥
closes #235
Expands
predict-genes-prodigal
to take SampleData[Contigs] as input.