Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: expand predict-genes-prodigal to take SampleData[Contigs] as input #236

Merged
merged 8 commits into from
Feb 10, 2025

Conversation

VinzentRisch
Copy link
Contributor

@VinzentRisch VinzentRisch commented Feb 4, 2025

closes #235

Expands predict-genes-prodigal to take SampleData[Contigs] as input.

@VinzentRisch VinzentRisch changed the title ENH: Expanded predict-genes-prodigal to take SampleData[Contigs] as input. ENH: Expanded predict-genes-prodigal to take SampleData[Contigs] as input Feb 4, 2025
@VinzentRisch VinzentRisch requested a review from misialq February 5, 2025 16:08
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (b6d068a) to head (cbaf022).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   95.60%   95.29%   -0.32%     
==========================================
  Files          34       34              
  Lines        1956     1997      +41     
  Branches      226      238      +12     
==========================================
+ Hits         1870     1903      +33     
- Misses         48       51       +3     
- Partials       38       43       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just a small comment below. Let's wait for @pmomocabr to test it out before merging ⏳

In the meantime, could you please investigate what happened in the CI tests?

q2_annotate/prodigal/prodigal.py Outdated Show resolved Hide resolved
@misialq
Copy link
Contributor

misialq commented Feb 6, 2025

Also, could you please review the parameter/input/output descriptions in the plugin_setup.py? It seems like some of those require updating too 🙏

q2_annotate/plugin_setup.py Outdated Show resolved Hide resolved
@VinzentRisch
Copy link
Contributor Author

VinzentRisch commented Feb 7, 2025

So I had a look at the CI failure. It only happens in the macos build but locally the tests run fine.
There is an assertation that os.remove is called once a specific path.

The first call is the correct one:
call('/var/folders/db/x5_t5x655c9_rftmy0wp2t2w0000gn/T/qiime2/runner/processes/26598-1738857143.653269@runner/tmp/q2-OutPath-51u5bu3m/taxdmp.zip'),

The the 4 calls after that look like this:
call(PosixPath('/var/folders/db/x5_t5x655c9_rftmy0wp2t2w0000gn/T/qiime2/runner/processes/26598-1738857143.653269@runner/a565edc1-0bf4-4357-80db-90bef9e8ec63.935881698569870148')),

So it looks like MacOS CI automatically deletes temporary files and is calling os.remove to do so.

To solve this I will change the assertion to: mock_os_rm.assert_any_call(zip_path)

What I dont understand is why is it only now a problem.

@VinzentRisch VinzentRisch requested a review from misialq February 7, 2025 14:06
@misialq misialq changed the title ENH: Expanded predict-genes-prodigal to take SampleData[Contigs] as input ENH: expand predict-genes-prodigal to take SampleData[Contigs] as input Feb 10, 2025
Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@misialq misialq merged commit b230268 into bokulich-lab:main Feb 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Expand predict-genes-prodigal to take SampleData[Contigs] as input.
2 participants