Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize toleration and nodeSelector for Flow Jobs #18

Open
pestebogdan opened this issue Mar 30, 2021 · 2 comments · Fixed by #25
Open

Parametrize toleration and nodeSelector for Flow Jobs #18

pestebogdan opened this issue Mar 30, 2021 · 2 comments · Fixed by #25
Labels
enhancement New feature or request project: flow

Comments

@pestebogdan
Copy link

Is your request related to a problem? Please describe.
At the moment, we have to adapt the K8s environment labels and taints to accomodate the Flow installation due to the hardcoded values for tolerations and nodeSelector.

Describe the solution you'd like
Ability to declare tolerations and NodeSelector in the flow helm chart, so some templating needs to happen there but I believe it first needs to occur here: https://github.com/boomerang-io/flow.service.controller/blob/ceb52aac3ffa25f7fda7caf32995d1fc17b34b5f/src/main/java/net/boomerangplatform/kube/service/HelperKubeServiceImpl.java#L158-L166

Describe the benefits or justification for this request
Not conditioning platform owners with a specific value for taints/tolerations and labels for the nodes where the dedicvated flow jobs need to run.

@pestebogdan pestebogdan added the enhancement New feature or request label Mar 30, 2021
@tlawrie
Copy link
Member

tlawrie commented Sep 20, 2021

Hi Bogdan. I have updated the helm chart to accept dynamic nodeSelector and Tolerations. These are then passed through to the tasks.

For example, on Google Cloud, it doesn't allow you to alter the Kubernetes node role so I have set that to a custom one in testing.

@tlawrie
Copy link
Member

tlawrie commented Sep 20, 2021

Need to complete documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request project: flow
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants