Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum Adjacency Search: should unit tests be relaxed to allow multiple correct orderings in the result? #338

Open
jeremy-murphy opened this issue May 1, 2023 · 0 comments

Comments

@jeremy-murphy
Copy link
Contributor

When @daankolthof added more tests to MAS, it occurred to me that different but equally correct implementations of the algorithm might return different orderings when tie-breaking edges with equal weights. I haven't confirmed that this is a real problem, it's just a suspicion.

Assuming I'm right, the principle here is that unit tests should be written to test the implementation against the specification, not against itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant