Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOTP] Add git #23

Open
sysophost opened this issue Feb 27, 2024 · 1 comment
Open

[LOTP] Add git #23

sysophost opened this issue Feb 27, 2024 · 1 comment
Labels
good first issue Good for newcomers idea

Comments

@sysophost
Copy link

Description of the LOTP tool

git is often present in CI pipelines where repos are pulled in at build time. Being able to control GIT_SSH or GIT_SSH_COMMAND in the pipeline environment variables could result in code execution on build hosts where direct access to the host isn't possible.

Ref

@sysophost sysophost added the idea label Feb 27, 2024
@sysophost sysophost changed the title [LOTP] Add X [LOTP] Add git Feb 27, 2024
@fproulx-boostsecurity
Copy link
Contributor

@sysophost that's absolutely correct and there is another PR open now #15
The reason I'm not jumping to include it is because the scenario you are describing is not well aligned with all the others I've been focusing so far. You are 100% right that if attacker controls those, there is RCE, but it's very unlikely in an average GitHub Actions workflow for instance. The example given in the PR ^ is via a file, so that is a bit more likely, but still, GitHub not allow pushing .git/config, so you cannot have that unless in the workflow you explicitely a template from the repo over to .git/config, which I'm seen in practice, so I'm willing to accept that PR more or less as proposed.

@fproulx-boostsecurity fproulx-boostsecurity added the good first issue Good for newcomers label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers idea
Projects
None yet
Development

No branches or pull requests

2 participants