Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript #157

Open
vinterdo opened this issue Sep 24, 2019 · 1 comment
Open

TypeScript #157

vinterdo opened this issue Sep 24, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@vinterdo
Copy link

v4

Issue Type

  • Bug

Description

Typings file (index.d.ts) contain invalid typings. Not only they are not compiling (typos, using "bool" instead of "boolean", "function" instead of "Function", but also they prevent me from using bootstrap styled-components (eg. components are not accepting props like a name on button, causing compilation error)

The temporary workaround is to manually delete typings file from node_modules. It works just fine then. Problem is that this workaround is fine when I'm developing on my pc, pretty unusable on the CI server.

Steps to reproduce

Just use bootstrap-styled in any typescript project... It won't compile

Versions

  • v4: 3.1.5
@bootstrap-styled bootstrap-styled locked as too heated and limited conversation to collaborators Sep 24, 2019
@kopax kopax added the bug Something isn't working label Sep 24, 2019
@kopax kopax changed the title TypeScript typings are broken (not compiling, typings inconsistent with documentation) TypeScript Sep 26, 2019
@kopax
Copy link
Contributor

kopax commented Sep 26, 2019

We have removed the typings until we found typescript contributor.

Please use bootstrap-styled/bootstrap-styled#83 for typescript discussion in bootstrap-styled

@kopax kopax added enhancement New feature or request and removed bug Something isn't working labels Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants