Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to ignore some annotations #114

Open
fredleger opened this issue Feb 8, 2021 · 1 comment
Open

Ability to ignore some annotations #114

fredleger opened this issue Feb 8, 2021 · 1 comment

Comments

@fredleger
Copy link

Seems that managed fields are killing the concept of katafygio.

I didn't looked for my katafygio repo for a while because it was working quite good but i recently discovered that there was a lots of commits in the repo. The main reason seems to be there is a lot of changes in annotations

Some exemples:

image
image

I can think about one way to solve that kind of issues with a generic approach by allowing filtering out some jsponpath address or similar .metatda.annotations that won't count into the diff comparison

what do you think ?

@bpineau
Copy link
Owner

bpineau commented Mar 15, 2021

Changes in your example all come from managedFields which indeed are irrelevant and noisy. Those are filtered out in recent releases, can you try an upgrade?

Other than that, annotations shouldn't be noisier than an other field. Generically stripping chosen fields might be possible yes, though could cause bad surprises when defined cluster wide, unless expressed as per object, or kind, or namespace (which becomes more involved). Whenever possible I'd like to fix pathological cases (like managedFields were).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants