Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WMBO build unsat classes #2

Open
hkir-dev opened this issue Nov 26, 2024 · 6 comments
Open

WMBO build unsat classes #2

hkir-dev opened this issue Nov 26, 2024 · 6 comments
Assignees

Comments

@hkir-dev
Copy link
Collaborator

WMBO build raised 11 unsatisfiable classes:

2024-11-26 14:16:05,548 ERROR org.obolibrary.robot.ReasonerHelper - There are 11 unsatisfiable classes in the ontology.
2024-11-26 14:16:05,549 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: https://purl.brain-bican.org/ontology/mbao/MBA_633
2024-11-26 14:16:05,549 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: https://purl.brain-bican.org/ontology/mbao/MBA_665
2024-11-26 14:16:05,549 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: https://purl.brain-bican.org/ontology/mbao/MBA_841
2024-11-26 14:16:05,549 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: https://purl.brain-bican.org/ontology/mbao/MBA_1016
2024-11-26 14:16:05,549 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: https://purl.brain-bican.org/ontology/mbao/MBA_1116
2024-11-26 14:16:05,549 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: https://purl.brain-bican.org/ontology/mbao/MBA_658
2024-11-26 14:16:05,549 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: https://purl.brain-bican.org/ontology/mbao/MBA_900
2024-11-26 14:16:05,549 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: https://purl.brain-bican.org/ontology/mbao/MBA_506
2024-11-26 14:16:05,549 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: https://purl.brain-bican.org/ontology/mbao/MBA_62
2024-11-26 14:16:05,549 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: https://purl.brain-bican.org/ontology/mbao/MBA_482
2024-11-26 14:16:05,549 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: https://purl.brain-bican.org/ontology/mbao/MBA_158

Explanation of unsats: wmbo_explanation.md

Can you recommend a solution to fix the unsatisfiable classes?

@hkir-dev
Copy link
Collaborator Author

some may be related with brain-bican/human_brain_atlas_ontology#2

@dosumis
Copy link

dosumis commented Nov 26, 2024

No time to look in detail now, but I would expect these to be showing up in the MBA build

brachium of the inferior colliculus SubClassOf Nothing

Nothing to do with cell types etc being added.

(Also - PNS CNS subdivision in Uberon is a perenial pain in the ass)

brachium of the inferior colliculus SubClassOf Nothing

hypoglossal nerve SubClassOf Nothing

cranial nerves SubClassOf Nothing

superior colliculus commissure SubClassOf Nothing

tectothalamic pathway SubClassOf Nothing

dorsal acoustic stria SubClassOf Nothing

lateral lemniscus SubClassOf Nothing

olfactory nerve layer of main olfactory bulb SubClassOf Nothing

optic chiasm SubClassOf Nothing

accessory spinal nerve SubClassOf Nothing

motor root of the trigeminal nerve SubClassOf Nothing

trapezoid body SubClassOf Nothing

trochlear nerve decussation SubClassOf Nothing

oculomotor nerve SubClassOf Nothing

cervicothalamic tract SubClassOf Nothing

optic tract SubClassOf Nothing

lateral olfactory tract, body SubClassOf Nothing

spinal tract of the trigeminal nerve SubClassOf Nothing

inferior colliculus commissure SubClassOf Nothing

vagus nerve SubClassOf Nothing

olfactory nerve SubClassOf Nothing

optic nerve SubClassOf Nothing

genu of the facial nerve SubClassOf Nothing

anterior commissure, olfactory limb SubClassOf Nothing

sensory root of the trigeminal nerve SubClassOf Nothing

cochlear nerve SubClassOf Nothing

vestibular nerve SubClassOf Nothing

posterior commissure SubClassOf Nothing

medial longitudinal fascicle SubClassOf Nothing

glossopharyngeal nerve SubClassOf Nothing

medial lemniscus SubClassOf Nothing

dorsal limb SubClassOf Nothing

dorsal roots SubClassOf Nothing

lateral olfactory tract, general SubClassOf Nothing

facial nerve SubClassOf Nothing

trochlear nerve SubClassOf Nothing

abducens nerve SubClassOf Nothing

trigeminal nerve SubClassOf Nothing

accessory optic tract SubClassOf Nothing

vestibulocochlear nerve SubClassOf Nothing

brachium of the superior colliculus SubClassOf Nothing

Axiom Impact

Axioms used 41 times

Axioms used 39 times

Axioms used 37 times

Axioms used 21 times

Axioms used 19 times

Axioms used 15 times

Axioms used 7 times

Axioms used 6 times

Axioms used 5 times

Axioms used 3 times

Axioms used 2 times

Axioms used 1 times

Ontologies used:

@dosumis
Copy link

dosumis commented Nov 26, 2024

Didn't we attempt to fix these before by classifying as nerve roots?

@hkir-dev
Copy link
Collaborator Author

It was only done for HBA terms obophenotype/uberon#3281

@dosumis
Copy link

dosumis commented Nov 27, 2024

Odd that MBA ODK passes.

Re fix: are the relationships between MBA terms coming from LinkML-OWL? If so trying to think through options to over-ride. A table or tables of curated relationships -->
Slightly hacky curated delete and replace using SPARQL update following LinkML-OWL build?

@hkir-dev
Copy link
Collaborator Author

MBA ODK is an older version (v1.4, latest is v1.6), so probably it doesn't have those checks.

Yes, parent_structure_id property in the structure graph is used to drive the hierarchy between MBA terms using LinkML. But we have a python script that drive this operation, so we can over-ride some relations if needed using a curation table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants