From 641e5d8a37cea00f0ceda179fdccb85abbeecf10 Mon Sep 17 00:00:00 2001 From: Alexej Leinweber Date: Mon, 6 May 2024 12:11:42 +0200 Subject: [PATCH] fix: Remove redundant condition for config-check --- composer.json | 2 +- .../DependencyInjection/BrainbitsBlockingExtension.php | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/composer.json b/composer.json index ace37a1..7ab019e 100644 --- a/composer.json +++ b/composer.json @@ -20,7 +20,7 @@ "matthiasnoback/symfony-config-test": "^5.1", "matthiasnoback/symfony-dependency-injection-test": "^5.1", "mikey179/vfsstream": "^1.6.11", - "phpstan/phpstan": "^1.10", + "phpstan/phpstan": "^1.10.67", "phpunit/phpunit": "^10.5", "predis/predis": "^2.2", "symfony/clock": "^6.4|^7.0", diff --git a/src/Bundle/DependencyInjection/BrainbitsBlockingExtension.php b/src/Bundle/DependencyInjection/BrainbitsBlockingExtension.php index a58bc71..0062e1b 100644 --- a/src/Bundle/DependencyInjection/BrainbitsBlockingExtension.php +++ b/src/Bundle/DependencyInjection/BrainbitsBlockingExtension.php @@ -15,12 +15,12 @@ use Brainbits\Blocking\Owner\OwnerFactoryInterface; use Brainbits\Blocking\Storage\StorageInterface; -use InvalidArgumentException; use Symfony\Component\Config\FileLocator; use Symfony\Component\DependencyInjection\ContainerBuilder; use Symfony\Component\DependencyInjection\Loader\YamlFileLoader; use Symfony\Component\HttpKernel\DependencyInjection\Extension; +use function assert; use function sprintf; class BrainbitsBlockingExtension extends Extension @@ -32,10 +32,7 @@ public function load(array $configs, ContainerBuilder $container): void $yamlLoader->load('services.yaml'); $configuration = $this->getConfiguration($configs, $container); - if ($configuration === null) { - // phpcs:ignore Brainbits.Exception.GlobalException.GlobalException - throw new InvalidArgumentException('Configuration not found.'); - } + assert($configuration instanceof Configuration); $config = $this->processConfiguration($configuration, $configs);