Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't found ECH in Flags setting #36904

Closed
dipras opened this issue Mar 18, 2024 · 4 comments
Closed

Can't found ECH in Flags setting #36904

dipras opened this issue Mar 18, 2024 · 4 comments

Comments

@dipras
Copy link

dipras commented Mar 18, 2024

Description

So i want to activated the ECH(Encrypted Client Hello) in brave, but i don't find the flag. I check on other computer with same OS, it has the flag to activate it. I wonder why it's only my device that doesn't have itu

Steps to Reproduce

  1. Install Brave browser from official website
  2. Open brave://flags/#encrypted-client-hello
  3. Search for "Encrypted"
  4. And the result, is not found what i exptexted

Actual result:

image
As you can see, i tried to search it but it not find the flex

Expected result:

It should be show the flag to enable/disable it

Reproduces how often:

Brave version (brave://version info)

1.63.169

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@fmarier
Copy link
Member

fmarier commented Mar 18, 2024

The flag was removed in upstream Chromium because the feature is enabled by default now: https://chromium-review.googlesource.com/c/chromium/src/+/5100554

@dipras
Copy link
Author

dipras commented Mar 19, 2024

The flag was removed in upstream Chromium because the feature is enabled by default now: https://chromium-review.googlesource.com/c/chromium/src/+/5100554

image
But when i check my browser using https://cloudflare.com/ssl/encrypted-sni. Its detected the ECH is not activated

Different case with my firefox
Screenshot_20240319_125744

@dipras
Copy link
Author

dipras commented Mar 19, 2024

Wait, Thing got different when i tried to launch it from terminal, now my browser have activated SNI

Hmmm this is weird

@dipras dipras closed this as completed Mar 19, 2024
@vanyasem
Copy link

vanyasem commented Dec 12, 2024

@fmarier would it be possible to somehow add the flag back?

Russia recently started blocking all ECH-enabled connections, making numerous websites inaccessible: https://adguard-dns.io/en/blog/encrypted-client-hello-misconceptions-future.html

See net4people/bbs#417 for more details

@vanyasem vanyasem mentioned this issue Dec 12, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants