-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When opening a PDF on Desktop, sometimes tab doesn't show in tab list #43700
Comments
Could not reproduce the issue in
2025-02-03_11h07_23.mp4 |
Reproduced the issue on
|
Looks like issue is fixed and working fine. I am unable to reproduce the issue on the following build.
|
Seems like it has been solved with brave/brave-core#27477 |
Quick note - when I had the issue, it wasn't limited exclusively to PDF. Since upgrading to 1.77.16, I too have not seen this yet 😄 |
The above requires |
Verification PASSED on
Verified the STR from the description and ensured that the issue is fixed and working fine. |
Description
When Brave is setup to handle/open PDFs by default, I noticed that opening a PDF did not show the open tab in the list of tabs.
The tabs don't seem to refresh after opening the PDF. If you click
New Tab
, then it'll force an update where the tab shows (along with an empty NTP).Possibly caused by brave/brave-core#27431 - this PR is preventing unnecessary re-renders of the tabs area. But it could be contributing to this bug.
cc: @simonhong
Steps to reproduce
Actual result
The document always seems to open.
However, sometimes it doesn't show the open tab in the list of tabs. For example, if I open "clifton.pdf" I'll see the document open but I won't see "clifton.pdf" in any of the open tabs.
If you click
New Tab
, then it seems to force a refresh - then the "clifton.pdf" and a blank new tab will be open.Expected result
Tab should always show
Reproduces how often
Intermittent issue
Brave version (brave://version info)
Channel information
Reproducibility
Miscellaneous information
No response
The text was updated successfully, but these errors were encountered: