Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When opening a PDF on Desktop, sometimes tab doesn't show in tab list #43700

Closed
1 of 6 tasks
bsclifton opened this issue Feb 3, 2025 · 7 comments · Fixed by brave/brave-core#27477
Closed
1 of 6 tasks

Comments

@bsclifton
Copy link
Member

Description

When Brave is setup to handle/open PDFs by default, I noticed that opening a PDF did not show the open tab in the list of tabs.

The tabs don't seem to refresh after opening the PDF. If you click New Tab, then it'll force an update where the tab shows (along with an empty NTP).

Possibly caused by brave/brave-core#27431 - this PR is preventing unnecessary re-renders of the tabs area. But it could be contributing to this bug.

cc: @simonhong

Steps to reproduce

  1. Have vertical tabs enabled
  2. Have Brave open
  3. Have Brave setup to open PDF files. For example, if you double click a PDF in Windows, it should open in Brave (default application for PDF). After setting, you may need to restart.
  4. Double click a PDF on your desktop

Actual result

The document always seems to open.

However, sometimes it doesn't show the open tab in the list of tabs. For example, if I open "clifton.pdf" I'll see the document open but I won't see "clifton.pdf" in any of the open tabs.

If you click New Tab, then it seems to force a refresh - then the "clifton.pdf" and a blank new tab will be open.

Expected result

Tab should always show

Reproduces how often

Intermittent issue

Brave version (brave://version info)

Brave		1.77.10 Chromium: 133.0.6943.39 (Official Build) nightly (64-bit) 
Revision	2f0a7f93d99c180ce71ddde77743ab6652afd8b5
OS		Windows 11 Version 24H2 (Build 26100.2894)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@bsclifton bsclifton changed the title When opening a PDF from explorer.exe, sometimes tab doesn't show in tab list When opening a PDF on Desktop, sometimes tab doesn't show in tab list Feb 3, 2025
@MadhaviSeelam
Copy link

Could not reproduce the issue in

Brave | 1.77.10 Chromium: 133.0.6943.39 (Official Build) nightly (64-bit)
-- | --
Revision | 2f0a7f93d99c180ce71ddde77743ab6652afd8b5
OS | Windows 11 Version 24H2 (Build 26100.2894)
2025-02-03_11h07_23.mp4

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 4, 2025

Reproduced the issue on

Brave | 1.77.10 Chromium: 133.0.6943.39 (Official Build) nightly (64-bit)
-- | --
Revision | 2f0a7f93d99c180ce71ddde77743ab6652afd8b5
OS | Windows 10 Version 22H2 (Build 19045.5371)

https://bravesoftware.slack.com/archives/C7VLGSR55/p1738654220480319?thread_ts=1738604208.926639&cid=C7VLGSR55

@GeetaSarvadnya
Copy link

Looks like issue is fixed and working fine. I am unable to reproduce the issue on the following build.

Brave | 1.77.14 Chromium: 133.0.6943.39 (Official Build) nightly (64-bit)
-- | --
Revision | 7ee065e7645b34232a63b7d3ee5cd2a4287cc72e
OS | Windows 10 Version 22H2 (Build 19045.5440)

@bsclifton
Copy link
Member Author

Seems like it has been solved with brave/brave-core#27477

@bsclifton
Copy link
Member Author

Quick note - when I had the issue, it wasn't limited exclusively to PDF.
When I opened a web link inside of the Slack application (not PWA), the tab opened basically didn't show in tabs bar.

Since upgrading to 1.77.16, I too have not seen this yet 😄

@kjozwiak
Copy link
Member

kjozwiak commented Feb 5, 2025

The above requires 1.75.175 or higher for 1.75.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.75.175 Chromium: 133.0.6943.54 (Official Build) (64-bit)
-- | --
Revision | 8e82be95a27b2e442e0099307c0c8ad6d12adcf0
OS | Windows 10 Version 22H2 (Build 19045.5440)

Verified the STR from the description and ensured that the issue is fixed and working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment