Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old (v1) reverse swap methods, models, bindings #922

Open
ok300 opened this issue Apr 10, 2024 · 0 comments
Open

Remove old (v1) reverse swap methods, models, bindings #922

ok300 opened this issue Apr 10, 2024 · 0 comments

Comments

@ok300
Copy link
Contributor

ok300 commented Apr 10, 2024

When the new reverse swap methods were introduced, the existing v1 ones were deprecated but still supported.

Eventually we will want to remove the v1 methods and associated bindings, models:

  • max_reverse_swap_amount
  • fetch_reverse_swap_fees
  • send_onchain
  • in_progress_reverse_swaps

In the CLI, this means

  • remove the [swap-out] group of commands
  • rename the [swap-out-v2] command description prefix to [swap-out]
@ok300 ok300 changed the title Remove existing (old) reverse swap methods, models, bindings Remove existing (v1) reverse swap methods, models, bindings Apr 10, 2024
@ok300 ok300 changed the title Remove existing (v1) reverse swap methods, models, bindings Remove old (v1) reverse swap methods, models, bindings Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant