Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controlled shutdown #13

Open
razorfog opened this issue Aug 22, 2017 · 1 comment
Open

Controlled shutdown #13

razorfog opened this issue Aug 22, 2017 · 1 comment

Comments

@razorfog
Copy link

Forky makes it difficult to operate graceful shutdowns in environments such as Heroku that blast all processes with SIGTERM on shutdown.

Forky has a flag shuttingDown that if it exported directly or via a setter function to allow it to be set to true, it could prevent the restart of child processes during the exit.

Is there a reason the flag shuttingDown is not exposed and seems to be a defacto constant? It might be a bug.

It's a real easy fix to allow a setter for shuttingDown and I'd put up a PR for that if it's something the admins would agree to.

@brianc
Copy link
Owner

brianc commented Aug 22, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants