You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Forky makes it difficult to operate graceful shutdowns in environments such as Heroku that blast all processes with SIGTERM on shutdown.
Forky has a flag shuttingDown that if it exported directly or via a setter function to allow it to be set to true, it could prevent the restart of child processes during the exit.
Is there a reason the flag shuttingDown is not exposed and seems to be a defacto constant? It might be a bug.
It's a real easy fix to allow a setter for shuttingDown and I'd put up a PR for that if it's something the admins would agree to.
The text was updated successfully, but these errors were encountered:
On Tue, Aug 22, 2017 at 12:49 PM, zap-unitive ***@***.***> wrote:
Forky makes it difficult to operate graceful shutdowns in environments
such as Heroku that blast all processes with SIGTERM on shutdown.
Forky has a flag shuttingDown that if it exported directly or via a
setter function to allow it to be set to true, it could prevent the restart
of child processes during the exit.
Is there a reason the flag shuttingDown is not exposed and seems to be a
defacto constant? It might be a bug.
It's a real easy fix to allow a setter for shuttingDown and I'd put up a
PR for that if it's something the admins would agree to.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#13>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADDobHIhnzcYNNX5W7be1UDtKMvJ5qGks5saxTEgaJpZM4O-90h>
.
Forky makes it difficult to operate graceful shutdowns in environments such as Heroku that blast all processes with SIGTERM on shutdown.
Forky has a flag
shuttingDown
that if it exported directly or via a setter function to allow it to be set to true, it could prevent the restart of child processes during the exit.Is there a reason the flag
shuttingDown
is not exposed and seems to be a defacto constant? It might be a bug.It's a real easy fix to allow a setter for
shuttingDown
and I'd put up a PR for that if it's something the admins would agree to.The text was updated successfully, but these errors were encountered: