Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.3.5 warnings #924

Open
jaredcwhite opened this issue Oct 12, 2024 · 2 comments
Open

Ruby 3.3.5 warnings #924

jaredcwhite opened this issue Oct 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jaredcwhite
Copy link
Member

I got warnings that both fiddle and rdoc had to be added to the Gemfile because they won't be in future Ruby 3.5 stdlibs. Not sure yet what that's all about. Add to bundle add them both to remove the warnings.

@jaredcwhite jaredcwhite added the bug Something isn't working label Oct 12, 2024
@ianbayne
Copy link
Contributor

I'm not sure about the fiddle warning, but the rdoc warning looks like it's coming from irb directly: https://bugs.ruby-lang.org/issues/20713#note-6. Checking that issue, I think what's meant by this comment is that if we were to add irb to the gemspec, we'd no longer get this warning.

I'd like to test this, but I'm not especially knowledgeable about gem development. I guess that I would need to update bridgetown-core/bridgetown-core.gemspec and re-build and re-install the gem. Doing so, however, I get symlink-related errors:

➜  gem install /bridgetown/bridgetown-builder-2.0.0.beta3.gem
ERROR:  While executing gem ... (Gem::Package::SymlinkError)
    installing symlink 'bridgetown-core/test/source/src/symlink-test/symlinked-file-outside-source' pointing to parent path /etc/passwd of /.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/bridgetown-builder-2.0.0.beta3 is not allowed

I could reject all symlink files in the gemspec, something like:

spec.files = `git ls-files -z`.split("\x0").reject { |f| File.symlink?(f) }

but I don't konw if that's the right way to go about this (spidey sense says no). Any help would be much appreciated 🙇

@ianbayne
Copy link
Contributor

As an addition to the above, note that I only saw the warnings about fiddle and rdoc when running bin/bridgetown console, which led to me suspecting that this is irb-related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants
@jaredcwhite @ianbayne and others