Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AN-305 No more stewarding of scala #7664

Merged
merged 1 commit into from
Dec 5, 2024
Merged

AN-305 No more stewarding of scala #7664

merged 1 commit into from
Dec 5, 2024

Conversation

jgainerdewar
Copy link
Collaborator

@jgainerdewar jgainerdewar commented Dec 4, 2024 •
edited
Loading

Description

We decided long ago not to use scala steward but it attacks us every once in a while, hoping this will stop it.

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

@jgainerdewar jgainerdewar requested a review from a team as a code owner December 4, 2024 22:06
aednichols
aednichols approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:meow_knife:

@AlexITC
Copy link
Collaborator

AlexITC commented Dec 5, 2024 •
edited
Loading

FYI: The problem is that cromwell is still included in the public steward repos, the updates should stop flowing once its removed from this file (look for broadinstitute/cromwell ): https://github.com/VirtusLab/scala-steward-repos/blob/main/repos-github.md

@jgainerdewar
Copy link
Collaborator Author

Thanks for the pointer @AlexITC ! Created VirtusLab/scala-steward-repos#487

@jgainerdewar jgainerdewar merged commit e917e52 into develop Dec 5, 2024
39 checks passed
@jgainerdewar jgainerdewar deleted the jd_AN-305 branch December 5, 2024 15:22
lucymcnatt pushed a commit that referenced this pull request Dec 9, 2024
@jgainerdewar @lucymcnatt
AN-305 No more stewarding of scala (#7664)
e3c77f6 
formatting again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucymcnatt lucymcnatt lucymcnatt approved these changes

@aednichols aednichols aednichols approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgainerdewar @AlexITC @aednichols @lucymcnatt